This is an archive of the discontinued LLVM Phabricator instance.

Avoid string comparisons on the fast path of MLIR Identifier lookup (NFC)
ClosedPublic

Authored by mehdi_amini on Jan 31 2021, 6:58 PM.

Diff Detail

Event Timeline

mehdi_amini created this revision.Jan 31 2021, 6:58 PM
mehdi_amini requested review of this revision.Jan 31 2021, 6:58 PM
rriddle accepted this revision.Feb 1 2021, 11:09 AM
rriddle added inline comments.
mlir/lib/IR/MLIRContext.cpp
733

This is still the fast path when in single threaded mode, unless we don't really care about that one?

This revision is now accepted and ready to land.Feb 1 2021, 11:09 AM

Avoid the string comparison on the single-thread fast-path

This revision was landed with ongoing or failed builds.Feb 1 2021, 1:05 PM
This revision was automatically updated to reflect the committed changes.