This is an archive of the discontinued LLVM Phabricator instance.

Differential D95733

[AMDGPU] Set s-memtime-inst feature from clang
ClosedPublic

Authored by rampitec on Jan 30 2021, 1:29 AM.

Details

Reviewers
kzhuravl
Commits
rG8e661d3d9c52: [AMDGPU] Set s-memtime-inst feature from clang

Diff Detail

Event Timeline

rampitec created this revision.Jan 30 2021, 1:29 AM
Herald added subscribers: kerbowa, t-tye, tpr and 4 others. · View Herald TranscriptJan 30 2021, 1:29 AM
rampitec requested review of this revision.Jan 30 2021, 1:29 AM
Herald added a subscriber: wdng. · View Herald TranscriptJan 30 2021, 1:29 AM
kzhuravl accepted this revision.Feb 1 2021, 1:50 PM

LGTM

This revision is now accepted and ready to land.Feb 1 2021, 1:50 PM
Closed by commit rG8e661d3d9c52: [AMDGPU] Set s-memtime-inst feature from clang (authored by rampitec). · Explain WhyFeb 1 2021, 2:20 PM
This revision was automatically updated to reflect the committed changes.
rampitec added a commit: rG8e661d3d9c52: [AMDGPU] Set s-memtime-inst feature from clang.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2021, 2:20 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
2 lines
test/
CodeGenOpenCL/
48 lines

Diff 320601

clang/lib/Basic/Targets/AMDGPU.cpp

Show First 20 Lines • Show All 204 Lines • ▼ Show 20 Lines case GK_GFX1010:
Features["ci-insts"] = true; Features["ci-insts"] = true;
Features["flat-address-space"] = true; Features["flat-address-space"] = true;
Features["16-bit-insts"] = true; Features["16-bit-insts"] = true;
Features["dpp"] = true; Features["dpp"] = true;
Features["gfx8-insts"] = true; Features["gfx8-insts"] = true;
Features["gfx9-insts"] = true; Features["gfx9-insts"] = true;
Features["gfx10-insts"] = true; Features["gfx10-insts"] = true;
Features["s-memrealtime"] = true; Features["s-memrealtime"] = true;
Features["s-memtime-inst"] = true;
break; break;
case GK_GFX908: case GK_GFX908:
Features["dot3-insts"] = true; Features["dot3-insts"] = true;
Features["dot4-insts"] = true; Features["dot4-insts"] = true;
Features["dot5-insts"] = true; Features["dot5-insts"] = true;
Features["dot6-insts"] = true; Features["dot6-insts"] = true;
Features["mai-insts"] = true; Features["mai-insts"] = true;
LLVM_FALLTHROUGH; LLVM_FALLTHROUGH;
Show All 26 Lines if (isAMDGCN(getTriple())) {
case GK_GFX701: case GK_GFX701:
case GK_GFX700: case GK_GFX700:
Features["ci-insts"] = true; Features["ci-insts"] = true;
Features["flat-address-space"] = true; Features["flat-address-space"] = true;
LLVM_FALLTHROUGH; LLVM_FALLTHROUGH;
case GK_GFX602: case GK_GFX602:
case GK_GFX601: case GK_GFX601:
case GK_GFX600: case GK_GFX600:
Features["s-memtime-inst"] = true;
break; break;
case GK_NONE: case GK_NONE:
break; break;
default: default:
llvm_unreachable("Unhandled GPU!"); llvm_unreachable("Unhandled GPU!");
} }
} else { } else {
if (CPU.empty()) if (CPU.empty())
▲ Show 20 Lines • Show All 167 Lines • Show Last 20 Lines

clang/test/CodeGenOpenCL/amdgpu-features.cl

Show All 26 Lines
// RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1010 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1010 %s // RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1010 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1010 %s
// RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1011 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1011 %s // RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1011 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1011 %s
// RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1012 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1012 %s // RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1012 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1012 %s
// RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1030 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1030 %s // RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1030 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1030 %s
// RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1031 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1031 %s // RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1031 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1031 %s
// RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1032 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1032 %s // RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1032 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1032 %s
// RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1033 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1033 %s // RUN: %clang_cc1 -triple amdgcn -target-cpu gfx1033 -S -emit-llvm -o - %s | FileCheck --check-prefix=GFX1033 %s
// GFX600-NOT: "target-features" // GFX600: "target-features"="+s-memtime-inst"
// GFX601-NOT: "target-features" // GFX601: "target-features"="+s-memtime-inst"
// GFX602-NOT: "target-features" // GFX602: "target-features"="+s-memtime-inst"
// GFX700: "target-features"="+ci-insts,+flat-address-space" // GFX700: "target-features"="+ci-insts,+flat-address-space,+s-memtime-inst"
// GFX701: "target-features"="+ci-insts,+flat-address-space" // GFX701: "target-features"="+ci-insts,+flat-address-space,+s-memtime-inst"
// GFX702: "target-features"="+ci-insts,+flat-address-space" // GFX702: "target-features"="+ci-insts,+flat-address-space,+s-memtime-inst"
// GFX703: "target-features"="+ci-insts,+flat-address-space" // GFX703: "target-features"="+ci-insts,+flat-address-space,+s-memtime-inst"
// GFX704: "target-features"="+ci-insts,+flat-address-space" // GFX704: "target-features"="+ci-insts,+flat-address-space,+s-memtime-inst"
// GFX705: "target-features"="+ci-insts,+flat-address-space" // GFX705: "target-features"="+ci-insts,+flat-address-space,+s-memtime-inst"
// GFX801: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime" // GFX801: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime,+s-memtime-inst"
// GFX802: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime" // GFX802: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime,+s-memtime-inst"
// GFX803: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime" // GFX803: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime,+s-memtime-inst"
// GFX805: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime" // GFX805: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime,+s-memtime-inst"
// GFX810: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime" // GFX810: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+s-memrealtime,+s-memtime-inst"
// GFX900: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX900: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX902: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX902: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX904: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX904: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX906: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX906: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX908: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot3-insts,+dot4-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+mai-insts,+s-memrealtime" // GFX908: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot3-insts,+dot4-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+mai-insts,+s-memrealtime,+s-memtime-inst"
// GFX909: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX909: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX90C: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX90C: "target-features"="+16-bit-insts,+ci-insts,+dpp,+flat-address-space,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX1010: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dpp,+flat-address-space,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX1010: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dpp,+flat-address-space,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX1011: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX1011: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX1012: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX1012: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime,+s-memtime-inst"
// GFX1030: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-3-insts,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX1030: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-3-insts,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime"
// GFX1031: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-3-insts,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX1031: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-3-insts,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime"
// GFX1032: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-3-insts,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX1032: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-3-insts,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime"
// GFX1033: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-3-insts,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime" // GFX1033: "target-features"="+16-bit-insts,+ci-insts,+dl-insts,+dot1-insts,+dot2-insts,+dot5-insts,+dot6-insts,+dpp,+flat-address-space,+gfx10-3-insts,+gfx10-insts,+gfx8-insts,+gfx9-insts,+s-memrealtime"
kernel void test() {} kernel void test() {}