Make OpenMP's lit.cfg python 3 compatible

[thieta]

Summary

This fails currently like this:

llvm-lit: /Users/tobias/code/llvm-releases/12.0.0/rc1/llvm-project/llvm/utils/lit/lit/TestingConfig.py:99: fatal: unable to parse config file '/Users/tobias/code/llvm-releases/12.0.0/rc1/llvm-project/openmp/runtime/test/lit.cfg', traceback: Traceback (most recent call last):
  File "/Users/tobias/code/llvm-releases/12.0.0/rc1/Phase3/Release/llvmCore-12.0.0-rc1.obj/bin/../../../../llvm-project/llvm/utils/lit/lit/TestingConfig.py", line 88, in load_from_path
    exec(compile(data, path, 'exec'), cfg_globals, None)
  File "/Users/tobias/code/llvm-releases/12.0.0/rc1/llvm-project/openmp/runtime/test/lit.cfg", line 82, in <module>
    config.test_flags += " -isysroot " + out
TypeError: can only concatenate str (not "bytes") to str

[protze.joachim]

Next time please provide the full context of the change as suggested in the guide: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

openmp/runtime/test/lit.cfg

79

Isn't strip() also a string method? I'd expect that you want to decode first, then strip.

[thieta]

openmp/runtime/test/lit.cfg

79

strip() works on byte objects as well as far as I can understand the python docs.

[thieta]

In D95669#2530360, @protze.joachim wrote:

Next time please provide the full context of the change as suggested in the guide: https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Ah yeah I can make sure to do that. I usually do but I was lazy since I did the patch on a remote machine without arc. But will try to not take shortcuts in the future!

[protze.joachim]

Ok, I found bytes.strip() in the documentation.
LGTM

openmp/runtime/test/lit.cfg

if config.operating_system == 'Darwin':
     if config.using_hwloc:
         config.test_flags += " -Wl,-rpath," + config.hwloc_library_dir
 
 # Find the SDK on Darwin
 if config.operating_system == 'Darwin':
   cmd = subprocess.Popen(['xcrun', '--show-sdk-path'],
                          stdout=subprocess.PIPE, stderr=subprocess.PIPE)
   out, err = cmd.communicate()
-  out = out.strip()
+  out = out.strip().decode()
   res = cmd.wait()
   if res == 0 and out:
     config.test_flags += " -isysroot " + out
 
 # Disable OMPT tests if FileCheck was not found
 if config.has_ompt and config.test_filecheck == "":
     lit_config.note("Not testing OMPT because FileCheck was not found")
     config.has_ompt = False