This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][NVPTX] Added the missing -O1 when building NVPTX bitcode libraries
ClosedPublic

Authored by tianshilei1992 on Jan 27 2021, 10:25 AM.

Details

Summary

In the past -O1 was used when building NVPTX bitcode libraries. After
we switched to OpenMP, -O1 was missing by mistake, leading to a huge performance
regression.

Diff Detail

Event Timeline

tianshilei1992 requested review of this revision.Jan 27 2021, 10:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2021, 10:25 AM
openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
130

Also align these commands at different lines

JonChesterfield accepted this revision.Jan 27 2021, 10:27 AM

Ah, yes. That would be slower. Thanks

This revision is now accepted and ready to land.Jan 27 2021, 10:27 AM

Does O1 create TBAA? we might need -O3 -Xclang -disable-llvm-optzns or -Xclang -disable-O0-optnone if we can also remove the noinline that way.

we need to put this in 12 as well, I think we need to open a bug that blocks the 12 meta-bug and start adding these patches (or git hashes) to be included in the release branch.

Does O1 create TBAA? we might need -O3 -Xclang -disable-llvm-optzns or -Xclang -disable-O0-optnone if we can also remove the noinline that way.

Yes, TBAA is created.

This revision was landed with ongoing or failed builds.Jan 28 2021, 5:13 AM
This revision was automatically updated to reflect the committed changes.