This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Disallow unused prefixes under clang/test/CodeGen
ClosedPublic

Authored by mtrofin on Jan 25 2021, 9:21 PM.

Diff Detail

Event Timeline

mtrofin requested review of this revision.Jan 25 2021, 9:21 PM
mtrofin created this revision.
Herald added a project: Restricted Project. · View Herald Transcript
MaskRay accepted this revision.Jan 25 2021, 9:29 PM

Thanks!

clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-lvalue.cpp
2

Not: these tests can be generalized a bit: -triple x86_64-linux-gnu -> -triple x86_64 (because they work for generic ELF and are not tied to Linux), but there is probably no reason to cause that churn since it has been committed.

3

If the intention of CHECK-NOSANITIZE is to explicitly check there is no sanitizer variable, it should use some -NOT: patterns. However, sanitizer variables should be obvious so that can be omitted.

This revision is now accepted and ready to land.Jan 25 2021, 9:29 PM
This revision was automatically updated to reflect the committed changes.