Details
Details
Diff Detail
Diff Detail
- Repository
 - rG LLVM Github Monorepo
 
Event Timeline
Comment Actions
Thanks!
| clang/test/CodeGen/catch-alignment-assumption-attribute-align_value-on-lvalue.cpp | ||
|---|---|---|
| 2 | Not: these tests can be generalized a bit: -triple x86_64-linux-gnu -> -triple x86_64 (because they work for generic ELF and are not tied to Linux), but there is probably no reason to cause that churn since it has been committed.  | |
| 3 | If the intention of CHECK-NOSANITIZE is to explicitly check there is no sanitizer variable, it should use some -NOT: patterns. However, sanitizer variables should be obvious so that can be omitted.  | |
Not: these tests can be generalized a bit: -triple x86_64-linux-gnu -> -triple x86_64 (because they work for generic ELF and are not tied to Linux), but there is probably no reason to cause that churn since it has been committed.