This is an archive of the discontinued LLVM Phabricator instance.

Fix x86 exegesis tests after c042aff8860df3cad2b274bf0a495e83ae36ddee
ClosedPublic

Authored by davezarzycki on Jan 23 2021, 8:07 AM.

Details

Summary

In c042aff8860df3cad2b274bf0a495e83ae36ddee, unused FileCheck prefixes became an error, which exposed some testing bugs in four exegesis tests. I've tried my best to either fix the testing bugs, or expand the testing to cover more scenarios.

Diff Detail

Event Timeline

davezarzycki created this revision.Jan 23 2021, 8:07 AM
davezarzycki requested review of this revision.Jan 23 2021, 8:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2021, 8:07 AM
davezarzycki edited the summary of this revision. (Show Details)Jan 23 2021, 8:12 AM
lebedev.ri accepted this revision.Jan 24 2021, 4:32 AM

I didn't re-read all the tests, but this seems about right, assuming they still pass now.

This revision is now accepted and ready to land.Jan 24 2021, 4:32 AM
This revision was landed with ongoing or failed builds.Jan 24 2021, 5:51 AM
This revision was automatically updated to reflect the committed changes.