Add AVR to update_llc_test_checks.py along with several tests.
Details
Diff Detail
Event Timeline
It might be worth adding a test in llvm/test/tools/UpdateTestChecks/update_llc_test_checks/ but I'd say that's not essential to land this patch.
| llvm/test/CodeGen/AVR/neg.ll | ||
|---|---|---|
| 14–15 | These incorrect CHECK lines should be removed. | |
| llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/avr_function_name.ll | ||
|---|---|---|
| 5 | Some existing files have such ; lines but they just editing the file harder. So they should be deleted. | |
You missed a main test file in llvm/test/tools/UpdateTestChecks/update_llc_test_checks/ (and add a REQUIRES:)
Sorry. I forget to do "git add -A" for some files. Now they are all added. You are appreciated to help me review again. :)
| llvm/test/tools/UpdateTestChecks/update_llc_test_checks/Inputs/avr_generated_funcs.ll.generated.expected | ||
|---|---|---|
| 1 | I'd say the avr_function_name.ll test is sufficient to show that the script works for AVR. This test is not actually testing for any generated functions (I guess -enable-machine-outliner does nothing?) | |
These incorrect CHECK lines should be removed.