Page MenuHomePhabricator

[clang][cli] NFC: Pass CC1Option explicitly to BoolOption
ClosedPublic

Authored by jansvoboda11 on Jan 22 2021, 5:18 AM.

Details

Summary

When Bool{F,G}Option were introduced, they were designed after the existing Opt{In,Out}FFlag in that they implied CC1Option for the ChangedBy flag.

This means less typing, but can be misleading in situations when the ResetBy has explicit CC1Option and ChangedBy doesn't.

This patch stops implicitly putting CC1Option to ChangedBy flag.

Diff Detail

Event Timeline

jansvoboda11 created this revision.Jan 22 2021, 5:18 AM
jansvoboda11 requested review of this revision.Jan 22 2021, 5:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 22 2021, 5:18 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
dexonsmith accepted this revision.Jan 22 2021, 7:43 AM

LGTM; this is much better!

This revision is now accepted and ready to land.Jan 22 2021, 7:43 AM
This revision was landed with ongoing or failed builds.Jan 25 2021, 12:16 AM
This revision was automatically updated to reflect the committed changes.