This is an archive of the discontinued LLVM Phabricator instance.

Differential D95131

[CodeComplete] Add ranged for loops code pattern.
ClosedPublic

Authored by njames93 on Jan 21 2021, 6:07 AM.

Details

Reviewers
sammccall
kadircet
klimek
rsmith
Commits
rGd18c3c7b18e9: [CodeComplete] Add ranged for loops code pattern.
Summary

Add code pattersn for c++ range for loops and objective c for...in loops.

Diff Detail

Event Timeline

njames93 requested review of this revision.Jan 21 2021, 6:07 AM
njames93 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 21 2021, 6:07 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B86075: Diff 318175.Jan 21 2021, 6:42 AM
kadircet accepted this revision.Jan 22 2021, 1:55 AM

thanks, lgtm!

This revision is now accepted and ready to land.Jan 22 2021, 1:55 AM
Closed by commit rGd18c3c7b18e9: [CodeComplete] Add ranged for loops code pattern. (authored by njames93). · Explain WhyJan 22 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.
njames93 added a commit: rGd18c3c7b18e9: [CodeComplete] Add ranged for loops code pattern..

Revision Contents

PathSize
clang/
lib/
Sema/
23 lines

Diff 318669

clang/lib/Sema/SemaCodeComplete.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,288 Lines • ▼ Show 20 Lines if (Results.includeCodePatterns()) {
Builder.AddChunk(CodeCompletionString::CK_RightParen); Builder.AddChunk(CodeCompletionString::CK_RightParen);
Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
Builder.AddChunk(CodeCompletionString::CK_LeftBrace); Builder.AddChunk(CodeCompletionString::CK_LeftBrace);
Builder.AddChunk(CodeCompletionString::CK_VerticalSpace); Builder.AddChunk(CodeCompletionString::CK_VerticalSpace);
Builder.AddPlaceholderChunk("statements"); Builder.AddPlaceholderChunk("statements");
Builder.AddChunk(CodeCompletionString::CK_VerticalSpace); Builder.AddChunk(CodeCompletionString::CK_VerticalSpace);
Builder.AddChunk(CodeCompletionString::CK_RightBrace); Builder.AddChunk(CodeCompletionString::CK_RightBrace);
Results.AddResult(Result(Builder.TakeString())); Results.AddResult(Result(Builder.TakeString()));
if (SemaRef.getLangOpts().CPlusPlus11 || SemaRef.getLangOpts().ObjC) {
// for ( range_declaration (:|in) range_expression ) { statements }
Builder.AddTypedTextChunk("for");
Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
Builder.AddChunk(CodeCompletionString::CK_LeftParen);
Builder.AddPlaceholderChunk("range-declaration");
Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
if (SemaRef.getLangOpts().ObjC)
Builder.AddTextChunk("in");
else
Builder.AddChunk(CodeCompletionString::CK_Colon);
Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
Builder.AddPlaceholderChunk("range-expression");
Builder.AddChunk(CodeCompletionString::CK_RightParen);
Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace);
Builder.AddChunk(CodeCompletionString::CK_LeftBrace);
Builder.AddChunk(CodeCompletionString::CK_VerticalSpace);
Builder.AddPlaceholderChunk("statements");
Builder.AddChunk(CodeCompletionString::CK_VerticalSpace);
Builder.AddChunk(CodeCompletionString::CK_RightBrace);
Results.AddResult(Result(Builder.TakeString()));
}
} }
if (S->getContinueParent()) { if (S->getContinueParent()) {
// continue ; // continue ;
Builder.AddTypedTextChunk("continue"); Builder.AddTypedTextChunk("continue");
Builder.AddChunk(CodeCompletionString::CK_SemiColon); Builder.AddChunk(CodeCompletionString::CK_SemiColon);
Results.AddResult(Result(Builder.TakeString())); Results.AddResult(Result(Builder.TakeString()));
} }
▲ Show 20 Lines • Show All 7,110 Lines • Show Last 20 Lines