[Dexter] add normcase conversion to visual studio's 'delete conditional breakpoint' method

[TWeaver]

Summary

Visual studio debugger breakpoints sometimes have uppercase or lowercase drive letters.

This quick fix simply normcases the parameter passed to _delete_conditional_breakpoint as well as the bound breakpoints File attribute for comparision.

[StephenTozer]

This looks good to me - does this need a test case?

[TWeaver]

Added more context to diff

[TWeaver]

In D95045#2522488, @StephenTozer wrote:

This looks good to me - does this need a test case?

I would argue this is minor enough to go in without one, but I'm happy to add one if you feel strongly in favour for a test going in too.

[StephenTozer]

In D95045#2522531, @TWeaver wrote:

I would argue this is minor enough to go in without one, but I'm happy to add one if you feel strongly in favour for a test going in too.

I'm not especially concerned about it, it does seem like it might be needless bloat - if anyone else disagrees however I'm not opposed to the adding of a test either, especially if there aren't many unit tests around here.

[jmorse]

IMO: change is fine, case sensitiveness on Windows is a more general problem that should be addressed generally. (We'll need to revisit this later).

[TWeaver]

No longer required as of D98699

debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py

class VisualStudio(DebuggerBase, metaclass=abc.ABCMeta):  # pylint: disable=abstract-method
 
     def _add_conditional_breakpoint(self, file_, line, condition):
         column = 1
         self._debugger.Breakpoints.Add('', file_, line, column, condition)
 
     def _delete_conditional_breakpoint(self, file_, line, condition):
         for bp in self._debugger.Breakpoints:
             for bound_bp in bp.Children:
-                if (bound_bp.File == file_ and bound_bp.FileLine == line and
+                file = os.path.normcase(file_)
+                bound_bp_file = os.path.normcase(bound_bp.File)
+                if (bound_bp_file == file and bound_bp.FileLine == line and
                     bound_bp.Condition == condition):
                     bp.Delete()
                     break
 
     def launch(self):
         self._fn_go()
 
     def step(self):