Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[flang][driver] Move isFixedFormSuffix and isFreeFormSuffix to flangFrontend

Authored by awarzynski on Jan 19 2021, 6:28 AM.



As highlighted in the post-commit review:

isFixedFormSuffix and isFreeFormSuffix should be defined in
flangFrontend rather than flangFrontendTool library. That's for 2

  • these methods are used in flangFrontend rather than flangFrontendTool
  • flangFrontendTool depends on flangFrontend

As mentioned on D94228, without this change shared library builds fails.

Diff Detail

Event Timeline

awarzynski created this revision.Jan 19 2021, 6:28 AM
awarzynski requested review of this revision.Jan 19 2021, 6:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2021, 6:28 AM
FarisRehman accepted this revision.EditedJan 19 2021, 7:29 AM

I've built the latest main branch with -DBUILD_SHARED_LIBS=On and it failed. Applying this patch has resolved that.
Looks good to me.

This revision is now accepted and ready to land.Jan 19 2021, 7:29 AM
This revision was landed with ongoing or failed builds.Jan 19 2021, 9:48 AM
This revision was automatically updated to reflect the committed changes.