This is an archive of the discontinued LLVM Phabricator instance.

Differential D94963

[compiler-rt] Silence a deprecation warning on FreeBSD
ClosedPublic

Authored by arichardson on Jan 19 2021, 4:59 AM.

Details

Reviewers
dim
emaste
jrtc27
Commits
rGcbcab14b19fc: [compiler-rt] Silence a deprecation warning on FreeBSD
Summary

On FreeVBD the sys/timeb.h header has a #warning that it's deprecated.
However, we need to include this header here, so silence this warning that
is printed multiple times otherwise.

Diff Detail

Event Timeline

arichardson created this revision.Jan 19 2021, 4:59 AM
Herald added a subscriber: dberris. · View Herald TranscriptJan 19 2021, 4:59 AM
arichardson requested review of this revision.Jan 19 2021, 4:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2021, 4:59 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B85702: Diff 317530.Jan 19 2021, 5:52 AM
arichardson added a comment.Mar 8 2021, 2:02 AM

ping?

dim accepted this revision.Mar 8 2021, 4:27 AM

Yes please, this warning has annoyed me for ages. I think we can't get rid of this include entirely, since we need to get at the declarations even if they are deprecated.

This revision is now accepted and ready to land.Mar 8 2021, 4:27 AM
dim added a comment.Mar 8 2021, 4:27 AM

Oh please s/FreeVBD/FreeBSD in the description before committing :)

Closed by commit rGcbcab14b19fc: [compiler-rt] Silence a deprecation warning on FreeBSD (authored by arichardson). · Explain WhyMar 10 2021, 3:18 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rGcbcab14b19fc: [compiler-rt] Silence a deprecation warning on FreeBSD.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
3 lines

Diff 329591

compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_freebsd.cpp

Show All 29 Lines
#include <sys/resource.h> #include <sys/resource.h>
#include <sys/signal.h> #include <sys/signal.h>
#include <sys/socket.h> #include <sys/socket.h>
#include <sys/sockio.h> #include <sys/sockio.h>
#include <sys/soundcard.h> #include <sys/soundcard.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/statvfs.h> #include <sys/statvfs.h>
#include <sys/time.h> #include <sys/time.h>
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-W#warnings"
#include <sys/timeb.h> #include <sys/timeb.h>
#pragma clang diagnostic pop
#include <sys/times.h> #include <sys/times.h>
#include <sys/timespec.h> #include <sys/timespec.h>
#include <sys/types.h> #include <sys/types.h>
#include <sys/ucontext.h> #include <sys/ucontext.h>
#include <sys/utsname.h> #include <sys/utsname.h>
// //
#include <arpa/inet.h> #include <arpa/inet.h>
#include <net/ethernet.h> #include <net/ethernet.h>
▲ Show 20 Lines • Show All 483 Lines • Show Last 20 Lines