This is an archive of the discontinued LLVM Phabricator instance.

Differential D94916

[ScalarizeMaskedMemIntrin] Add missing dependency
ClosedPublic

Authored by Fznamznon on Jan 18 2021, 7:58 AM.

Details

Reviewers
anna
craig.topper
aymanmus
Commits
rG7113de301a84: [ScalarizeMaskedMemIntrin] Add missing dependency
Summary

The pass has dependency on 'TargetTransformInfoWrapperPass', but the
corresponding call to INITIALIZE_PASS_DEPENDENCY was missing.

Diff Detail

Event Timeline

Fznamznon created this revision.Jan 18 2021, 7:58 AM
Herald added a subscriber: hiraditya. · View Herald TranscriptJan 18 2021, 7:58 AM
Fznamznon requested review of this revision.Jan 18 2021, 7:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2021, 7:58 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Fznamznon added reviewers: anna, craig.topper, aymanmus.Jan 18 2021, 8:07 AM
Harbormaster completed remote builds in B85602: Diff 317360.Jan 18 2021, 8:32 AM
craig.topper accepted this revision.Jan 18 2021, 10:25 AM

LGTM

This revision is now accepted and ready to land.Jan 18 2021, 10:25 AM
Closed by commit rG7113de301a84: [ScalarizeMaskedMemIntrin] Add missing dependency (authored by Fznamznon). · Explain WhyJan 19 2021, 11:35 AM
This revision was automatically updated to reflect the committed changes.
Fznamznon added a commit: rG7113de301a84: [ScalarizeMaskedMemIntrin] Add missing dependency.

Revision Contents

PathSize
llvm/
lib/
Transforms/
Scalar/
9 lines

Diff 317638

llvm/lib/Transforms/Scalar/ScalarizeMaskedMemIntrin.cpp

Show First 20 Lines • Show All 66 Lines • ▼ Show 20 Lines
static bool optimizeBlock(BasicBlock &BB, bool &ModifiedDT, static bool optimizeBlock(BasicBlock &BB, bool &ModifiedDT,
const TargetTransformInfo &TTI, const DataLayout &DL); const TargetTransformInfo &TTI, const DataLayout &DL);
static bool optimizeCallInst(CallInst *CI, bool &ModifiedDT, static bool optimizeCallInst(CallInst *CI, bool &ModifiedDT,
const TargetTransformInfo &TTI, const TargetTransformInfo &TTI,
const DataLayout &DL); const DataLayout &DL);
char ScalarizeMaskedMemIntrinLegacyPass::ID = 0; char ScalarizeMaskedMemIntrinLegacyPass::ID = 0;
INITIALIZE_PASS(ScalarizeMaskedMemIntrinLegacyPass, DEBUG_TYPE, INITIALIZE_PASS_BEGIN(ScalarizeMaskedMemIntrinLegacyPass, DEBUG_TYPE,
"Scalarize unsupported masked memory intrinsics", false, false) "Scalarize unsupported masked memory intrinsics", false,
false)
INITIALIZE_PASS_DEPENDENCY(TargetTransformInfoWrapperPass)
INITIALIZE_PASS_END(ScalarizeMaskedMemIntrinLegacyPass, DEBUG_TYPE,
"Scalarize unsupported masked memory intrinsics", false,
false)
FunctionPass *llvm::createScalarizeMaskedMemIntrinLegacyPass() { FunctionPass *llvm::createScalarizeMaskedMemIntrinLegacyPass() {
return new ScalarizeMaskedMemIntrinLegacyPass(); return new ScalarizeMaskedMemIntrinLegacyPass();
} }
static bool isConstantIntVector(Value *Mask) { static bool isConstantIntVector(Value *Mask) {
Constant *C = dyn_cast<Constant>(Mask); Constant *C = dyn_cast<Constant>(Mask);
if (!C) if (!C)
▲ Show 20 Lines • Show All 859 Lines • Show Last 20 Lines