Page MenuHomePhabricator

[mlir] Add Complex dialect.
ClosedPublic

Authored by pifon2a on Jan 15 2021, 4:25 AM.

Details

Summary

Add complex ops without removing them from Standard dialect yet.

https://llvm.discourse.group/t/rfc-split-the-complex-dialect-from-std/2496/2

Diff Detail

Event Timeline

pifon2a created this revision.Jan 15 2021, 4:25 AM
pifon2a requested review of this revision.Jan 15 2021, 4:25 AM
pifon2a edited the summary of this revision. (Show Details)Jan 15 2021, 4:26 AM
herhut accepted this revision.Jan 15 2021, 7:08 AM

This also adds the lowering to LLVM. Maybe mention this in the commit message or split it out.

mlir/include/mlir/Conversion/Passes.td
96

nit: space

mlir/include/mlir/Dialect/Complex/IR/ComplexOps.td
19

Are these needed? All uses of this override these and we should avoid needing any of this.

mlir/lib/Dialect/Complex/IR/ComplexDialect.cpp
2

Should these have the magic first line with filename and such?

mlir/lib/Dialect/Complex/IR/ComplexOps.cpp
2

Here, too.

This revision is now accepted and ready to land.Jan 15 2021, 7:08 AM
pifon2a updated this revision to Diff 317023.Jan 15 2021, 10:51 AM
pifon2a marked 4 inline comments as done.

Address the comments.

pifon2a updated this revision to Diff 317024.Jan 15 2021, 10:53 AM

Fix the typo.

This revision was landed with ongoing or failed builds.Jan 15 2021, 11:03 AM
This revision was automatically updated to reflect the committed changes.