This is an archive of the discontinued LLVM Phabricator instance.

Differential D94538

[ELF][NFCI] small cleanup to OutputSections.h
ClosedPublic

Authored by inglorion on Jan 12 2021, 11:40 AM.

Details

Reviewers
MaskRay
grimar
• espindola
Commits
rG6166b91e8371: [ELF][NFCI] small cleanup to OutputSections.h
Summary

OutputSections.h used to close the lld::elf namespace only to
immediately open it again. This change merges both parts into
one.

Diff Detail

Event Timeline

inglorion created this revision.Jan 12 2021, 11:40 AM
Herald added a reviewer: • espindola. · View Herald TranscriptJan 12 2021, 11:40 AM
Herald added subscribers: arichardson, emaste. · View Herald Transcript
inglorion requested review of this revision.Jan 12 2021, 11:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2021, 11:40 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
MaskRay accepted this revision.Jan 12 2021, 11:50 AM

LGTM.

This revision is now accepted and ready to land.Jan 12 2021, 11:50 AM
Harbormaster completed remote builds in B84886: Diff 316178.Jan 12 2021, 12:15 PM
Closed by commit rG6166b91e8371: [ELF][NFCI] small cleanup to OutputSections.h (authored by inglorion). · Explain WhyJan 12 2021, 3:10 PM
This revision was automatically updated to reflect the committed changes.
inglorion added a commit: rG6166b91e8371: [ELF][NFCI] small cleanup to OutputSections.h.

Revision Contents

PathSize
lld/
ELF/
6 lines

Diff 316252

lld/ELF/OutputSections.h

Show First 20 Lines • Show All 129 Lines • ▼ Show 20 Linesstruct Out {
static PhdrEntry *tlsPhdr; static PhdrEntry *tlsPhdr;
static OutputSection *elfHeader; static OutputSection *elfHeader;
static OutputSection *programHeaders; static OutputSection *programHeaders;
static OutputSection *preinitArray; static OutputSection *preinitArray;
static OutputSection *initArray; static OutputSection *initArray;
static OutputSection *finiArray; static OutputSection *finiArray;
}; };
} // namespace elf
} // namespace lld
namespace lld {
namespace elf {
uint64_t getHeaderSize(); uint64_t getHeaderSize();
extern std::vector<OutputSection *> outputSections; extern std::vector<OutputSection *> outputSections;
} // namespace elf } // namespace elf
} // namespace lld } // namespace lld
#endif #endif