This is an archive of the discontinued LLVM Phabricator instance.

Differential D94496

[mlir][CAPI] Fix inline function declaration
ClosedPublic

Authored by vinograd47 on Jan 12 2021, 7:38 AM.

Details

Reviewers
ftynse
mehdi_amini
Commits
rG4fa01f72de6c: [mlir][CAPI] Fix inline function declaration
Summary

Add static keyword, otherwise build fail with linker error for some cases.

Diff Detail

Event Timeline

vinograd47 created this revision.Jan 12 2021, 7:38 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 13 others. · View Herald TranscriptJan 12 2021, 7:38 AM
vinograd47 requested review of this revision.Jan 12 2021, 7:38 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptJan 12 2021, 7:38 AM
ftynse accepted this revision.Jan 12 2021, 7:44 AM
This revision is now accepted and ready to land.Jan 12 2021, 7:44 AM
ftynse mentioned this in D94497: [mlir] Define inline functions in headers as static.Jan 12 2021, 7:45 AM
This revision was landed with ongoing or failed builds.Jan 12 2021, 8:05 AM
Closed by commit rG4fa01f72de6c: [mlir][CAPI] Fix inline function declaration (authored by vinograd47, committed by ftynse). · Explain Why
This revision was automatically updated to reflect the committed changes.
ftynse added a commit: rG4fa01f72de6c: [mlir][CAPI] Fix inline function declaration.
Harbormaster completed remote builds in B84833: Diff 316090.Jan 12 2021, 8:08 AM

Revision Contents

PathSize
mlir/
include/
mlir-c/
2 lines

Diff 316096

mlir/include/mlir-c/AffineExpr.h

Show First 20 Lines • Show All 44 Lines • ▼ Show 20 Lines
mlirAffineExprGetContext(MlirAffineExpr affineExpr); mlirAffineExprGetContext(MlirAffineExpr affineExpr);
/// Returns `true` if the two affine expressions are equal. /// Returns `true` if the two affine expressions are equal.
MLIR_CAPI_EXPORTED bool mlirAffineExprEqual(MlirAffineExpr lhs, MLIR_CAPI_EXPORTED bool mlirAffineExprEqual(MlirAffineExpr lhs,
MlirAffineExpr rhs); MlirAffineExpr rhs);
/// Returns `true` if the given affine expression is a null expression. Note /// Returns `true` if the given affine expression is a null expression. Note
/// constant zero is not a null expression. /// constant zero is not a null expression.
inline bool mlirAffineExprIsNull(MlirAffineExpr affineExpr) { inline static bool mlirAffineExprIsNull(MlirAffineExpr affineExpr) {
return affineExpr.ptr == NULL; return affineExpr.ptr == NULL;
} }
/** Prints an affine expression by sending chunks of the string representation /** Prints an affine expression by sending chunks of the string representation
* and forwarding `userData to `callback`. Note that the callback may be called * and forwarding `userData to `callback`. Note that the callback may be called
* several times with consecutive chunks of the string. */ * several times with consecutive chunks of the string. */
MLIR_CAPI_EXPORTED void mlirAffineExprPrint(MlirAffineExpr affineExpr, MLIR_CAPI_EXPORTED void mlirAffineExprPrint(MlirAffineExpr affineExpr,
MlirStringCallback callback, MlirStringCallback callback,
▲ Show 20 Lines • Show All 150 Lines • Show Last 20 Lines