This is an archive of the discontinued LLVM Phabricator instance.

Differential D94292

[libc++] Sync TEST_HAS_TIMESPEC_GET and _LIBCPP_HAS_TIMESPEC_GET on FreeBSD
ClosedPublic

Authored by arichardson on Jan 8 2021, 3:45 AM.

Details

Reviewers
dim
ldionne
Group Reviewers
Restricted Project
Commits
rG077a84f91140: [libc++] Sync TEST_HAS_TIMESPEC_GET and _LIBCPP_HAS_TIMESPEC_GET on FreeBSD
Summary

Commit 5e416ba943b7c737deb8eca62756f7b4fa925845 (D71522) updated the
__config header but didn't change test_macros.h.
This fixes libcxx/language.support/has_timespec_get.compile.pass.cpp on
FreeBSD12/13.

Diff Detail

Event Timeline

arichardson created this revision.Jan 8 2021, 3:45 AM
Herald added subscribers: krytarowski, emaste. · View Herald TranscriptJan 8 2021, 3:45 AM
arichardson requested review of this revision.Jan 8 2021, 3:45 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 8 2021, 3:45 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
dim accepted this revision.Jan 8 2021, 4:38 AM

LGTM (this mirrors what is in libcxx/include/__config btw)

Harbormaster completed remote builds in B84444: Diff 315337.Jan 8 2021, 5:17 AM
ldionne accepted this revision.Jan 8 2021, 8:03 AM
ldionne added a subscriber: ldionne.

This duplication of several things in test_macros.h and __config is a bit annoying, but LGTM. At the same time, if we want to keep considering the test suite as a self standing thing, the duplication has to remain in some form.

This revision is now accepted and ready to land.Jan 8 2021, 8:03 AM
Closed by commit rG077a84f91140: [libc++] Sync TEST_HAS_TIMESPEC_GET and _LIBCPP_HAS_TIMESPEC_GET on FreeBSD (authored by arichardson). · Explain WhyJan 19 2021, 7:04 AM
This revision was automatically updated to reflect the committed changes.
arichardson added a commit: rG077a84f91140: [libc++] Sync TEST_HAS_TIMESPEC_GET and _LIBCPP_HAS_TIMESPEC_GET on FreeBSD.

Revision Contents

PathSize
libcxx/
test/
support/
6 lines

Diff 315337

libcxx/test/support/test_macros.h

Show First 20 Lines • Show All 161 Lines • ▼ Show 20 Lines
#else #else
# define TEST_CONSTEXPR_CXX20 # define TEST_CONSTEXPR_CXX20
#endif #endif
// Sniff out to see if the underlying C library has C11 features // Sniff out to see if the underlying C library has C11 features
// This is cribbed from __config; but lives here as well because we can't assume libc++ // This is cribbed from __config; but lives here as well because we can't assume libc++
#if __ISO_C_VISIBLE >= 2011 || TEST_STD_VER >= 11 #if __ISO_C_VISIBLE >= 2011 || TEST_STD_VER >= 11
# if defined(__FreeBSD__) # if defined(__FreeBSD__)
// Specifically, FreeBSD does NOT have timespec_get, even though they have all # if __FreeBSD_version >= 1300064 || \
// the rest of C11 - this is PR#38495 (__FreeBSD_version >= 1201504 && __FreeBSD_version < 1300000)
# define TEST_HAS_TIMESPEC_GET
# endif
# define TEST_HAS_ALIGNED_ALLOC # define TEST_HAS_ALIGNED_ALLOC
# define TEST_HAS_QUICK_EXIT # define TEST_HAS_QUICK_EXIT
# elif defined(__BIONIC__) # elif defined(__BIONIC__)
# if __ANDROID_API__ >= 21 # if __ANDROID_API__ >= 21
# define TEST_HAS_QUICK_EXIT # define TEST_HAS_QUICK_EXIT
# endif # endif
# if __ANDROID_API__ >= 28 # if __ANDROID_API__ >= 28
# define TEST_HAS_ALIGNED_ALLOC # define TEST_HAS_ALIGNED_ALLOC
▲ Show 20 Lines • Show All 197 Lines • Show Last 20 Lines