This is an archive of the discontinued LLVM Phabricator instance.

Differential D94262

Update syntax for tensor and memref types to match parser.
ClosedPublic

Authored by richard-uhler on Jan 7 2021, 1:42 PM.

Details

Reviewers
rriddle
mehdi_amini
Commits
rG762ffc95550c: Update syntax for tensor and memref types to match parser.
Summary

Based on the comments in lib/Parser/TypeParser.cpp on the
parseMemRefType and parseTensorType functions.

Diff Detail

Event Timeline

richard-uhler created this revision.Jan 7 2021, 1:42 PM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald TranscriptJan 7 2021, 1:42 PM
richard-uhler requested review of this revision.Jan 7 2021, 1:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2021, 1:42 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini added inline comments.Jan 7 2021, 2:05 PM
mlir/docs/LangRef.md
940

The strided layout is a valid part of the syntax. It is the code in TypeParser.cpp that isn't up to date I believe.

Harbormaster completed remote builds in B84383: Diff 315231.Jan 7 2021, 2:08 PM
richard-uhler updated this revision to Diff 315432.Jan 8 2021, 10:01 AM

Include strided-layout in the syntax for memref.

Herald added a reviewer: rriddle. · View Herald TranscriptJan 8 2021, 10:01 AM
richard-uhler marked an inline comment as done.Jan 8 2021, 10:01 AM
Harbormaster completed remote builds in B84488: Diff 315432.Jan 8 2021, 10:19 AM
mehdi_amini added inline comments.Jan 8 2021, 5:03 PM
mlir/lib/Parser/TypeParser.cpp
190 ↗(On Diff #315432)

I think this should be a semi-affine-map-composition

richard-uhler updated this revision to Diff 315823.Jan 11 2021, 9:06 AM

Use semi-affine-map-composition instead of semi-affine-map.

richard-uhler updated this revision to Diff 315825.Jan 11 2021, 9:08 AM

Include definition of semi-affine-map-composition syntax.

richard-uhler marked an inline comment as done.Jan 11 2021, 9:09 AM
mehdi_amini accepted this revision.Jan 11 2021, 9:10 AM
This revision is now accepted and ready to land.Jan 11 2021, 9:10 AM
richard-uhler added a comment.Jan 11 2021, 9:16 AM

Can you submit this for me?

Harbormaster completed remote builds in B84703: Diff 315823.Jan 11 2021, 9:25 AM
Harbormaster completed remote builds in B84704: Diff 315825.
Closed by commit rG762ffc95550c: Update syntax for tensor and memref types to match parser. (authored by richard-uhler, committed by mehdi_amini). · Explain WhyJan 11 2021, 2:57 PM
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG762ffc95550c: Update syntax for tensor and memref types to match parser..

Revision Contents

PathSize
mlir/
docs/
15 lines

Diff 315231

mlir/docs/LangRef.md

Show First 20 Lines • Show All 923 Lines • ▼ Show 20 Lines
#### Memref Type #### Memref Type
Syntax: Syntax:
``` ```
memref-type ::= ranked-memref-type | unranked-memref-type memref-type ::= ranked-memref-type | unranked-memref-type
ranked-memref-type ::= `memref` `<` dimension-list-ranked tensor-memref-element-type ranked-memref-type ::= `memref` `<` dimension-list-ranked type
(`,` layout-specification)? (`,` memory-space)? `>` (`,` semi-affine-map-composition)? (`,` memory-space)? `>`
unranked-memref-type ::= `memref` `<*x` tensor-memref-element-type unranked-memref-type ::= `memref` `<*x` type (`,` memory-space)? `>`
(`,` memory-space)? `>`
stride-list ::= `[` (dimension (`,` dimension)*)? `]` semi-affine-map-composition ::= (semi-affine-map `,` )* semi-affine-map
strided-layout ::= `offset:` dimension `,` `strides: ` stride-list
layout-specification ::= semi-affine-map | strided-layout
mehdi_aminiUnsubmitted
Done
ReplyInline Actions

The strided layout is a valid part of the syntax. It is the code in TypeParser.cpp that isn't up to date I believe.

mehdi_amini: The strided layout is a valid part of the syntax. It is the code in TypeParser.cpp that isn't…
memory-space ::= integer-literal /* | TODO: address-space-id */ memory-space ::= integer-literal /* | TODO: address-space-id */
``` ```
A `memref` type is a reference to a region of memory (similar to a buffer A `memref` type is a reference to a region of memory (similar to a buffer
pointer, but more powerful). The buffer pointed to by a memref can be allocated, pointer, but more powerful). The buffer pointed to by a memref can be allocated,
aliased and deallocated. A memref can be used to read and write data from/to the aliased and deallocated. A memref can be used to read and write data from/to the
memory region which it references. Memref types use the same shape specifier as memory region which it references. Memref types use the same shape specifier as
tensor types. Note that `memref<f32>`, `memref<0 x f32>`, `memref<1 x 0 x f32>`, tensor types. Note that `memref<f32>`, `memref<0 x f32>`, `memref<1 x 0 x f32>`,
▲ Show 20 Lines • Show All 247 Lines • ▼ Show 20 Lines
The `none` type is a unit type, i.e. a type with exactly one possible value, The `none` type is a unit type, i.e. a type with exactly one possible value,
where its value does not have a defined dynamic representation. where its value does not have a defined dynamic representation.
#### Tensor Type #### Tensor Type
Syntax: Syntax:
``` ```
tensor-type ::= `tensor` `<` dimension-list tensor-memref-element-type `>` tensor-type ::= `tensor` `<` dimension-list type `>`
tensor-memref-element-type ::= vector-element-type | vector-type | complex-type
// memref requires a known rank, but tensor does not.
dimension-list ::= dimension-list-ranked | (`*` `x`) dimension-list ::= dimension-list-ranked | (`*` `x`)
dimension-list-ranked ::= (dimension `x`)* dimension-list-ranked ::= (dimension `x`)*
dimension ::= `?` | decimal-literal dimension ::= `?` | decimal-literal
``` ```
Values with tensor type represents aggregate N-dimensional data values, and Values with tensor type represents aggregate N-dimensional data values, and
have a known element type. It may have an unknown rank (indicated by `*`) or may have a known element type. It may have an unknown rank (indicated by `*`) or may
have a fixed rank with a list of dimensions. Each dimension may be a static have a fixed rank with a list of dimensions. Each dimension may be a static
▲ Show 20 Lines • Show All 453 Lines • Show Last 20 Lines