This is an archive of the discontinued LLVM Phabricator instance.

Update syntax for tensor and memref types to match parser.
ClosedPublic

Authored by richard-uhler on Jan 7 2021, 1:42 PM.

Details

Summary

Based on the comments in lib/Parser/TypeParser.cpp on the
parseMemRefType and parseTensorType functions.

Diff Detail

Event Timeline

richard-uhler created this revision.Jan 7 2021, 1:42 PM
richard-uhler requested review of this revision.Jan 7 2021, 1:42 PM
mehdi_amini added inline comments.Jan 7 2021, 2:05 PM
mlir/docs/LangRef.md
940

The strided layout is a valid part of the syntax. It is the code in TypeParser.cpp that isn't up to date I believe.

Include strided-layout in the syntax for memref.

richard-uhler marked an inline comment as done.Jan 8 2021, 10:01 AM
mehdi_amini added inline comments.Jan 8 2021, 5:03 PM
mlir/lib/Parser/TypeParser.cpp
192

I think this should be a semi-affine-map-composition

Use semi-affine-map-composition instead of semi-affine-map.

Include definition of semi-affine-map-composition syntax.

richard-uhler marked an inline comment as done.Jan 11 2021, 9:09 AM
mehdi_amini accepted this revision.Jan 11 2021, 9:10 AM
This revision is now accepted and ready to land.Jan 11 2021, 9:10 AM

Can you submit this for me?

Harbormaster completed remote builds in B84704: Diff 315825.
This revision was automatically updated to reflect the committed changes.