This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Enable sret demotion
ClosedPublic

Authored by cdevadas on Jan 5 2021, 10:56 PM.

Details

Reviewers
arsenm

Diff Detail

Event Timeline

cdevadas created this revision.Jan 5 2021, 10:56 PM
cdevadas requested review of this revision.Jan 5 2021, 10:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 10:56 PM
arsenm added a comment.Jan 6 2021, 8:49 AM

I think we're missing a test that needs sret inserted and also has additional arguments

llvm/lib/Target/AMDGPU/AMDGPUCallLowering.h
45

You can get the context through the MachineFunction, so you can avoid this argument

cdevadas updated this revision to Diff 315107.Jan 7 2021, 5:08 AM

Added two more tests to address the review comment.

arsenm accepted this revision.Jan 7 2021, 6:04 AM
This revision is now accepted and ready to land.Jan 7 2021, 6:04 AM