Page MenuHomePhabricator

scudo: Fix compilation for non-Linux aarch64
ClosedPublic

Authored by mcgrathr on Jan 5 2021, 11:58 AM.

Details

Summary

Linux-specific aarch64 code was deconditionalized in commit
dfa40840e0e2fa094c5d3f441affe0785cdc8d09. This broke builds for
non-Linux aarch64 platforms.

Diff Detail

Unit TestsFailed

TimeTest
90 msx64 windows > Clang.Profile::branch-logical-mixed.cpp
Script: -- : 'RUN: at line 4'; c:\ws\w64\llvm-project\premerge-checks\build\bin\clang.exe -cc1 -internal-isystem c:\ws\w64\llvm-project\premerge-checks\build\lib\clang\12.0.0\include -nostdsysteminc -triple x86_64-pc-windows-gnu -std=c++11 -main-file-name branch-logical-mixed.cpp C:\ws\w64\llvm-project\premerge-checks\clang\test\Profile\branch-logical-mixed.cpp -o - -emit-llvm -fprofile-instrument=clang | c:\ws\w64\llvm-project\premerge-checks\build\bin\filecheck.exe -allow-deprecated-dag-overlap C:\ws\w64\llvm-project\premerge-checks\clang\test\Profile\branch-logical-mixed.cpp

Event Timeline

mcgrathr created this revision.Jan 5 2021, 11:58 AM
mcgrathr requested review of this revision.Jan 5 2021, 11:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 5 2021, 11:58 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
cryptoad accepted this revision.Jan 5 2021, 12:31 PM

Let's go with yours, better comments/whitespaces.

This revision is now accepted and ready to land.Jan 5 2021, 12:31 PM
This revision was landed with ongoing or failed builds.Jan 5 2021, 1:22 PM
This revision was automatically updated to reflect the committed changes.