This is an archive of the discontinued LLVM Phabricator instance.

Differential D93984

[doc] Place sha256 in lld/README.md into brackets
ClosedPublic

Authored by • emilengler on Jan 3 2021, 3:37 AM.

Details

Reviewers
• espindola
asl
Bigcheese
sbc100
smeenai
Commits
rGb117d17d264f: [doc] Place sha256 in lld/README.md into backticks

Diff Detail

Event Timeline

• emilengler requested review of this revision.Jan 3 2021, 3:37 AM
• emilengler created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2021, 3:37 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B83836: Diff 314272.Jan 3 2021, 4:17 AM
• emilengler added reviewers: • espindola, asl, Bigcheese, sbc100.Jan 3 2021, 11:56 AM
smeenai accepted this revision.Jan 3 2021, 7:14 PM
smeenai added a subscriber: smeenai.

LGTM, although did you mean "backticks" instead of "brackets" in the commit message?

Do you need this to be committed on your behalf?

This revision is now accepted and ready to land.Jan 3 2021, 7:14 PM
• emilengler added a comment.Jan 4 2021, 12:29 AM
In D93984#2476836, @smeenai wrote:

LGTM, although did you mean "backticks" instead of "brackets" in the commit message?

Do you need this to be committed on your behalf?

Yes, backticks is what I actually meant! It's fine changing the commit message to it.

smeenai added a comment.Jan 6 2021, 6:29 PM

What name and email address would you like this committed under?

• emilengler added a comment.Jan 10 2021, 3:11 AM

Oh sorry for me late reply!
Emil Engler <me@emilengler.com>

Closed by commit rGb117d17d264f: [doc] Place sha256 in lld/README.md into backticks (authored by • emilengler, committed by smeenai). · Explain WhyJan 12 2021, 10:20 AM
This revision was automatically updated to reflect the committed changes.
smeenai added a commit: rGb117d17d264f: [doc] Place sha256 in lld/README.md into backticks.
smeenai added a comment.Jan 12 2021, 10:20 AM

Thanks, I committed this. You might get some buildbot failure emails. Given the nature of this change, they're overwhelmingly likely to be false positives, but feel free to forward them to me if you want confirmation. (Search for me in LLVM's git log to get my email.)

Revision Contents

PathSize
lld/
2 lines

Diff 316157

lld/README.md

Show All 10 Lines
Benchmarking Benchmarking
============ ============
In order to make sure various developers can evaluate patches over the In order to make sure various developers can evaluate patches over the
same tests, we create a collection of self contained programs. same tests, we create a collection of self contained programs.
It is hosted at https://s3-us-west-2.amazonaws.com/linker-tests/lld-speed-test.tar.xz It is hosted at https://s3-us-west-2.amazonaws.com/linker-tests/lld-speed-test.tar.xz
The current sha256 is 10eec685463d5a8bbf08d77f4ca96282161d396c65bd97dc99dbde644a31610f. The current sha256 is `10eec685463d5a8bbf08d77f4ca96282161d396c65bd97dc99dbde644a31610f`.