Update UsersManual and OpenCLSupport pages to reflect recent functionality i.e. SPIR-V generation, C++ for OpenCL, OpenCL 3.0 development plans.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Looks good, only a few typos and minor comments.
clang/docs/OpenCLSupport.rst | ||
---|---|---|
73 | I'm not sure it matters, but just in case it messes up with the rendering: the last | is not aligned. | |
clang/docs/UsersManual.rst | ||
2832–2833 | ||
2864–2869 | This also applies to types I believe (e.g. int2). Maybe this paragraph should be slightly altered to reflect this? | |
2875 | ||
2877 | ||
2894 | I feel "provide" was slightly better. | |
3060 | ||
3242–3245 | ||
3279–3280 | ||
3309 |
clang/docs/UsersManual.rst | ||
---|---|---|
2864–2869 | Good point. I added types in too. The header contains only a few types but mainly functions but vector types are important for example. Although they should have been native keywords and they were until some refactoring was made. | |
2894 | True, now that I think about this from the user's perspective it's a better wording indeed. |
Thanks for the update. Looks good overall. A minor question about backticks. I'm no native English speaker, so I would recommend a second review from someone else too.
clang/docs/OpenCLSupport.rst | ||
---|---|---|
73 | Double backticks? | |
clang/docs/UsersManual.rst | ||
2877 | Do you also need to use double back-ticks here? I don't remember. |
Looks good to me, just some grammar nitpicks from my side.
(I only discovered the "Suggest Edit" feature halfway through the review; I didn't update the comments I already made as I'm not sure in which format you prefer them?)
clang/docs/OpenCLSupport.rst | ||
---|---|---|
36–38 | ||
51–159 | the enqueue_kernel builtin function is not supported | |
54 | lambdas | |
56 | destructors | |
67 | ||
clang/docs/UsersManual.rst | ||
2828 | Drop "file", or say "... produce a file test.bc that ..." | |
2832 | ||
2839 | Full stop. New sentence. | |
3057–3060 | identifier clashes | |
3058 | ||
3242–3248 |
(I only discovered the "Suggest Edit" feature halfway through the review; I didn't update the comments I already made as I'm not sure in which format you prefer them?)
I do like the feature but I wish it would be more useful like on github that you can update the patch automatically...
clang/docs/UsersManual.rst | ||
---|---|---|
2832 |