Page MenuHomePhabricator
Differential D93752

[mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to isConvertibleAndHasIdentityMaps().
ClosedPublic
Actions

Authored by csigg on Dec 23 2020, 2:21 AM.

Details

Reviewers
ftynse
herhut
Commits
rG19a0d0a40ce9: [mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to…

Diff Detail

Event Timeline

csigg created this revision.Dec 23 2020, 2:21 AM
Herald added a reviewer: ftynse. · View Herald TranscriptDec 23 2020, 2:21 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 15 others. · View Herald Transcript
csigg requested review of this revision.Dec 23 2020, 2:21 AM
Herald added a reviewer: herhut. · View Herald TranscriptDec 23 2020, 2:21 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ftynse accepted this revision.Dec 23 2020, 2:23 AM
ftynse added inline comments.
mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
514–515

Nit: could you also update the doc and fix the typo while you are here?

This revision is now accepted and ready to land.Dec 23 2020, 2:23 AM
herhut accepted this revision.Dec 23 2020, 2:30 AM

Thank you! Big improvement in naming.

csigg updated this revision to Diff 313518.Dec 23 2020, 2:42 AM

Rebase, update comment.

Harbormaster completed remote builds in B83381: Diff 313516.Dec 23 2020, 2:45 AM
Harbormaster completed remote builds in B83382: Diff 313518.Dec 23 2020, 3:14 AM
Closed by commit rG19a0d0a40ce9: [mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to… (authored by csigg). · Explain WhyDec 23 2020, 3:23 AM
This revision was automatically updated to reflect the committed changes.
csigg added a commit: rG19a0d0a40ce9: [mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to….

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Conversion/
StandardToLLVM/
5 lines
lib/
Conversion/
GPUCommon/
4 lines
StandardToLLVM/
13 lines

Diff 313526

View Options

mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h

Loading...
View Options

mlir/lib/Conversion/GPUCommon/ConvertLaunchFuncToRuntimeCalls.cpp

Loading...
View Options

mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp

Loading...