Page MenuHomePhabricator

[mlir] Rename ConvertToLLVMPattern::isSupportedMemRefType() to isConvertibleAndHasIdentityMaps().
ClosedPublic

Authored by csigg on Dec 23 2020, 2:21 AM.

Diff Detail

Event Timeline

csigg created this revision.Dec 23 2020, 2:21 AM
csigg requested review of this revision.Dec 23 2020, 2:21 AM
ftynse accepted this revision.Dec 23 2020, 2:23 AM
ftynse added inline comments.
mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
514–515

Nit: could you also update the doc and fix the typo while you are here?

This revision is now accepted and ready to land.Dec 23 2020, 2:23 AM
herhut accepted this revision.Dec 23 2020, 2:30 AM

Thank you! Big improvement in naming.

csigg updated this revision to Diff 313518.Dec 23 2020, 2:42 AM

Rebase, update comment.