This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Add OpenMP Documentation for Libomptarget environment variables
ClosedPublic

Authored by jhuber6 on Dec 22 2020, 12:16 PM.

Details

Summary

Add support to the OpenMP web pages for environment variables supported
by Libomptarget and their usage.

Diff Detail

Event Timeline

jhuber6 created this revision.Dec 22 2020, 12:16 PM
jhuber6 requested review of this revision.Dec 22 2020, 12:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 22 2020, 12:16 PM
jdoerfert accepted this revision.Dec 22 2020, 1:54 PM

LGTM, with some nits to be addressed prior to landing.

openmp/docs/design/Runtimes.rst
70

types of?

75

Mention how to build the application with debug information. And that the runtime doesn't need to be a debug runtime.

97

As discussed offload, let's unreserve the bit and make -1 print everything.

This revision is now accepted and ready to land.Dec 22 2020, 1:54 PM
jhuber6 updated this revision to Diff 313430.Dec 22 2020, 2:06 PM

Making suggested changes.

jhuber6 updated this revision to Diff 313432.Dec 22 2020, 2:19 PM

Changing ambiguous refernce to flags

This revision was landed with ongoing or failed builds.Dec 22 2020, 2:41 PM
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added inline comments.
openmp/docs/design/Runtimes.rst
63

It should be 8KB here.

jhuber6 added inline comments.Dec 23 2020, 8:48 AM
openmp/docs/design/Runtimes.rst
63

Thanks, made the change upstream. I was also missing a period.