This is an archive of the discontinued LLVM Phabricator instance.

Differential D93719

[OpenMP][Docs] Fixed a typo in the doc that can mislead users to a CMake error
ClosedPublic

Authored by tianshilei1992 on Dec 22 2020, 10:57 AM.

Details

Reviewers
ye-luo
jdoerfert
Commits
rG1eb082c2ea42: [OpenMP][Docs] Fixed a typo in the doc that can mislead users to a CMake error
Summary

When setting LLVM_ENABLE_RUNTIMES, lower case word should be used;
otherwise, it can cause a CMake error that specific path is not found.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Dec 22 2020, 10:57 AM
Herald added subscribers: guansong, yaxunl. · View Herald TranscriptDec 22 2020, 10:57 AM
tianshilei1992 requested review of this revision.Dec 22 2020, 10:57 AM
Herald added a reviewer: jdoerfert. · View Herald TranscriptDec 22 2020, 10:57 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
ye-luo accepted this revision.Dec 22 2020, 11:02 AM
This revision is now accepted and ready to land.Dec 22 2020, 11:02 AM
This revision was landed with ongoing or failed builds.Dec 22 2020, 11:06 AM
Closed by commit rG1eb082c2ea42: [OpenMP][Docs] Fixed a typo in the doc that can mislead users to a CMake error (authored by tianshilei1992). · Explain Why
This revision was automatically updated to reflect the committed changes.
tianshilei1992 added a commit: rG1eb082c2ea42: [OpenMP][Docs] Fixed a typo in the doc that can mislead users to a CMake error.
Harbormaster completed remote builds in B83307: Diff 313394.Dec 22 2020, 11:47 AM

Revision Contents

PathSize
openmp/
docs/
2 lines

Diff 313394

openmp/docs/SupportAndFAQ.rst

Show First 20 Lines • Show All 47 Lines • ▼ Show 20 Lines
.. _build_offload_capable_compiler: .. _build_offload_capable_compiler:
Q: How to build an OpenMP offload capable compiler? Q: How to build an OpenMP offload capable compiler?
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
To build an *effective* OpenMP offload capable compiler, only one extra CMake To build an *effective* OpenMP offload capable compiler, only one extra CMake
option, `LLVM_ENABLE_RUNTIMES="OPENMP"`, is needed when building LLVM (Generic option, `LLVM_ENABLE_RUNTIMES="openmp"`, is needed when building LLVM (Generic
information about building LLVM is available `here <https://llvm.org/docs/GettingStarted.html>`__.). information about building LLVM is available `here <https://llvm.org/docs/GettingStarted.html>`__.).
Make sure all backends that are targeted by OpenMP to be enabled. By default, Make sure all backends that are targeted by OpenMP to be enabled. By default,
Clang will be build with all backends enabled. Clang will be build with all backends enabled.
If your build machine is not the target machine or automatic detection of the If your build machine is not the target machine or automatic detection of the
available GPUs failed, you should also set: available GPUs failed, you should also set:
- `CLANG_OPENMP_NVPTX_DEFAULT_ARCH=sm_XX` where `XX` is the architecture of your GPU, e.g, 80. - `CLANG_OPENMP_NVPTX_DEFAULT_ARCH=sm_XX` where `XX` is the architecture of your GPU, e.g, 80.
Show All 18 Lines