This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Fixed the issue that CMake variables for OpenMP were not passed through when building OpenMP with LLVM_ENABLE_RUNTIMES
ClosedPublic

Authored by tianshilei1992 on Dec 20 2020, 2:08 PM.

Details

Summary

Currently when building OpenMP along with LLVM, CMake variables for OpenMP (prefix with LIBOMP and LIBOMPTARGET) will not be passed through because by default it uses the prefix of the runtime name, aka OPENMP in this case. This patch fixed this issue.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Dec 20 2020, 2:08 PM
tianshilei1992 requested review of this revision.Dec 20 2020, 2:08 PM
Herald added a project: Restricted Project. · View Herald Transcript
tianshilei1992 edited the summary of this revision. (Show Details)Dec 20 2020, 2:10 PM
jdoerfert accepted this revision.Dec 20 2020, 3:36 PM

LGTM, cool! Thanks for tracking this down!

This revision is now accepted and ready to land.Dec 20 2020, 3:36 PM

I'd remove the [NFC] tag though.

tianshilei1992 retitled this revision from [OpenMP][NFC] Fixed the issue that CMake variables for OpenMP were not passed through when building OpenMP with LLVM_ENABLE_RUNTIMES to [OpenMP] Fixed the issue that CMake variables for OpenMP were not passed through when building OpenMP with LLVM_ENABLE_RUNTIMES.Dec 20 2020, 3:37 PM