This is an archive of the discontinued LLVM Phabricator instance.

[IndVars] Fix adding trunc instructions for unwind blocks
ClosedPublic

Authored by yrouban on Dec 17 2020, 8:12 PM.

Reviewers

mkazantsev
skatkov

Summary

We should not insert truncation before landing pads.
Fix the insertion point.

yrouban requested review of this revision.Dec 17 2020, 8:12 PM

Good catch!

This revision is now accepted and ready to land.Dec 17 2020, 8:32 PM

Could use a test.

In D93509#2462173, @lebedev.ri wrote:

Could use a test.

Ok. See D93521

Path

Size

llvm/

lib/

Transforms/

Utils/

2 lines

Show First 20 Lines • Show All 1,648 Lines • ▼ Show 20 Lines	for (PHINode *User : LCSSAPhiUsers) {
assert(User->getNumOperands() == 1 && "Checked before!");		assert(User->getNumOperands() == 1 && "Checked before!");
Builder.SetInsertPoint(User);		Builder.SetInsertPoint(User);
auto *WidePN =		auto *WidePN =
Builder.CreatePHI(WideBO->getType(), 1, User->getName() + ".wide");		Builder.CreatePHI(WideBO->getType(), 1, User->getName() + ".wide");
BasicBlock *LoopExitingBlock = User->getParent()->getSinglePredecessor();		BasicBlock *LoopExitingBlock = User->getParent()->getSinglePredecessor();
assert(LoopExitingBlock && L->contains(LoopExitingBlock) &&		assert(LoopExitingBlock && L->contains(LoopExitingBlock) &&
"Not a LCSSA Phi?");		"Not a LCSSA Phi?");
WidePN->addIncoming(WideBO, LoopExitingBlock);		WidePN->addIncoming(WideBO, LoopExitingBlock);
Builder.SetInsertPoint(User->getParent()->getFirstNonPHI());		Builder.SetInsertPoint(&*User->getParent()->getFirstInsertionPt());
auto *TruncPN = Builder.CreateTrunc(WidePN, User->getType());		auto *TruncPN = Builder.CreateTrunc(WidePN, User->getType());
User->replaceAllUsesWith(TruncPN);		User->replaceAllUsesWith(TruncPN);
DeadInsts.emplace_back(User);		DeadInsts.emplace_back(User);
}		}

for (ICmpInst *User : ICmpUsers) {		for (ICmpInst *User : ICmpUsers) {
Builder.SetInsertPoint(User);		Builder.SetInsertPoint(User);
auto ExtendedOp = [&](Value * V)->Value * {		auto ExtendedOp = [&](Value * V)->Value * {
▲ Show 20 Lines • Show All 424 Lines • Show Last 20 Lines