Page MenuHomePhabricator

[mlir] Partially update the conversion-to-llvm document
ClosedPublic

Authored by ftynse on Dec 17 2020, 12:39 PM.

Details

Summary

This document was not updated after the LLVM dialect type system had been
reimplemented and was using an outdated syntax. Rewrite the part of the
document that concerns type conversion and prepare the ground for splitting it
into a document that explains how built-in types are converted and a separate
document that explains how standard types and functions are converted, which
will better correspond to the fact that built-in types do not belong to the
standard dialect.

Diff Detail

Event Timeline

ftynse created this revision.Dec 17 2020, 12:39 PM
ftynse requested review of this revision.Dec 17 2020, 12:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2020, 12:39 PM
rriddle accepted this revision.Dec 17 2020, 12:57 PM
rriddle added inline comments.
mlir/docs/ConversionToLLVMDialect.md
80
This revision is now accepted and ready to land.Dec 17 2020, 12:57 PM
ftynse updated this revision to Diff 312593.Dec 17 2020, 12:59 PM

Address review.

ftynse marked an inline comment as done.Dec 17 2020, 1:00 PM
This revision was landed with ongoing or failed builds.Dec 17 2020, 1:00 PM
This revision was automatically updated to reflect the committed changes.