The build is failing because clang-tidy is complaining about not being able to find pybind.. I don't think this could be caused by my change, could it? This is my first patch to LLVM, so I'd appreciate any help on fixing this. Thanks in advance!
/mnt/disks/ssd0/agent/llvm-project/mlir/lib/Bindings/Python/PybindUtils.h:16:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error] #include <pybind11/pybind11.h> ^
The build is failing because clang-tidy is complaining about not being able to find pybind..
The image deployed to build machines does not have pybind.
Nit: please only use auto in cases where it improves readability, e.g. the type is too long to spell out (iterator) or is clear from the RHS (cast result). Here specifically, we don't see what is the result of mlirIdentifierStr so it's hard to locally understand that the ownership management is correct.