[mlir][Python] Add an Operation.name property

[siddharth-krishna]

The build is failing because clang-tidy is complaining about not being able to find pybind.. I don't think this could be caused by my change, could it? This is my first patch to LLVM, so I'd appreciate any help on fixing this. Thanks in advance!

/mnt/disks/ssd0/agent/llvm-project/mlir/lib/Bindings/Python/PybindUtils.h:16:10: error: 'pybind11/pybind11.h' file not found [clang-diagnostic-error]
#include <pybind11/pybind11.h>
         ^

[ftynse]

The build is failing because clang-tidy is complaining about not being able to find pybind..

The image deployed to build machines does not have pybind.

mlir/lib/Bindings/Python/IRModules.cpp

3047

Nit: please only use auto in cases where it improves readability, e.g. the type is too long to spell out (iterator) or is clear from the RHS (cast result). Here specifically, we don't see what is the result of mlirIdentifierStr so it's hard to locally understand that the ownership management is correct.

[siddharth-krishna]

Use exact types instead of auto

[siddharth-krishna]

Thanks! That's good to know, I've added the types explicitly. What is the next step for landing this patch?

[stellaraccident]

Thanks - I'll land the patch. (sorry for the delay - I've been offline for holidays)

[stellaraccident]

Rebase.

[siddharth-krishna]

Thank you! And happy new year to you all. :)

mlir/lib/Bindings/Python/IRModules.cpp

void mlir::python::populateIRSubmodule(py::module &m) {
   py::class_<PyOperation, PyOperationBase>(m, "Operation")
       .def_static("create", &PyOperation::create, py::arg("name"),
                   py::arg("operands") = py::none(),
                   py::arg("results") = py::none(),
                   py::arg("attributes") = py::none(),
                   py::arg("successors") = py::none(), py::arg("regions") = 0,
                   py::arg("loc") = py::none(), py::arg("ip") = py::none(),
                   kOperationCreateDocstring)
+      .def_property_readonly("name",
+                             [](PyOperation &self) {
+                               MlirOperation operation = self.get();
+                               MlirStringRef name = mlirIdentifierStr(
+                                   mlirOperationGetName(operation));
+                               return py::str(name.data, name.length);
+                             })
       .def_property_readonly(
           "context",
           [](PyOperation &self) { return self.getContext().getObject(); },
           "Context that owns the Operation")
       .def_property_readonly("opview", &PyOperation::createOpView);
 
   py::class_<PyOpView, PyOperationBase>(m, "OpView")
       .def(py::init<py::object>())

mlir/test/Bindings/Python/ir_operation.py

except Exception as e:
       # CHECK: Invalid attribute value for the key "some_key" when attempting to create the operation "module" (Unable to cast Python instance of type <class '_mlir.ir.Context'> to C++ type 'mlir::python::PyAttribute')
       print(e)
     try:
       Operation.create("module", attributes={"some_key":None})
     except Exception as e:
       # CHECK: Found an invalid (`None`?) attribute value for the key "some_key" when attempting to create the operation "module"
       print(e)
 run(testCreateWithInvalidAttributes)
+
+
+# CHECK-LABEL: TEST: testOperationName
+def testOperationName():
+  ctx = Context()
+  ctx.allow_unregistered_dialects = True
+  module = Module.parse(r"""
+    %0 = "custom.op1"() : () -> f32
+    %1 = "custom.op2"() : () -> i32
+    %2 = "custom.op1"() : () -> f32
+  """, ctx)
+
+  # CHECK: custom.op1
+  # CHECK: custom.op2
+  # CHECK: custom.op1
+  for op in module.body.operations:
+    print(op.operation.name)
+
+run(testOperationName)