Added definitions for 5.1 interop to omp.h.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Cool! I'm really happy to see this.
Given that we have a doxygen documentation for openmp now (not yet online but it can be build), we should start adding appropriate comments, especially to user facing functions. That should also give them information right in the IDE, which is arguably good.
That said, this file is used to create omp.h, right? If so, we should copy the description from the OpenMP standard here. Summary, maybe all of it.
FWIW, an early prototype can be found here https://github.com/jdoerfert/llvm-project/commit/c514fc3bfc22bee958f9aedde56dafee642bd381
openmp/runtime/src/include/omp.h.var | ||
---|---|---|
169 | Let's move it above the enum /// ... | |
172 | Do we really want/need to define it or can we provide a constant variable, nicer for debugging I think. |
openmp/runtime/src/include/omp.h.var | ||
---|---|---|
172 | I prefer defining it, and we also have similar definitions in omp-tools.h.var. |
Let's move it above the enum /// ...