This is an archive of the discontinued LLVM Phabricator instance.

Differential D93384

[mlir] Async: re-enable tests after fixing fkakines
ClosedPublic

Authored by ezhulenev on Dec 16 2020, 2:18 AM.

Details

Reviewers
mehdi_amini
Commits
rG900d71a851db: [mlir] Async: re-enable tests after fixing fkakines
Summary

Test flakiness was fixed by: https://github.com/llvm/llvm-project/commit/9edcedf7f222ce7c893d1e3bf19b3a7a1f0f2218

Runs these tests to verify that all parts of the lowering work correctly.

Diff Detail

Unit TestsFailed

TimeTest
70 msx64 windows > LLVM.CodeGen/XCore::threads.ll

Event Timeline

ezhulenev created this revision.Dec 16 2020, 2:18 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald TranscriptDec 16 2020, 2:18 AM
ezhulenev requested review of this revision.Dec 16 2020, 2:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 16 2020, 2:18 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
ezhulenev edited the summary of this revision. (Show Details)Dec 16 2020, 2:19 AM
Harbormaster completed remote builds in B82611: Diff 312160.Dec 16 2020, 2:46 AM
mehdi_amini accepted this revision.Dec 16 2020, 10:19 AM
This revision is now accepted and ready to land.Dec 16 2020, 10:19 AM
This revision was landed with ongoing or failed builds.Dec 16 2020, 11:07 AM
Closed by commit rG900d71a851db: [mlir] Async: re-enable tests after fixing fkakines (authored by ezhulenev). · Explain Why
This revision was automatically updated to reflect the committed changes.
ezhulenev added a commit: rG900d71a851db: [mlir] Async: re-enable tests after fixing fkakines.

Revision Contents

PathSize
mlir/
test/
mlir-cpu-runner/
20 lines
24 lines

Diff 312160

mlir/test/mlir-cpu-runner/async-group.mlir

// RUN: true // RUN: mlir-opt %s -async-ref-counting \
// TODO: re-enable when not flaky. // RUN: -convert-async-to-llvm \
// _UN: mlir-opt %s -async-ref-counting \ // RUN: -convert-std-to-llvm \
// _UN: -convert-async-to-llvm \ // RUN: | mlir-cpu-runner \
// _UN: -convert-std-to-llvm \ // RUN: -e main -entry-point-result=void -O0 \
// _UN: | mlir-cpu-runner \ // RUN: -shared-libs=%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext \
// _UN: -e main -entry-point-result=void -O0 \ // RUN: -shared-libs=%linalg_test_lib_dir/libmlir_runner_utils%shlibext \
// _UN: -shared-libs=%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext \ // RUN: -shared-libs=%linalg_test_lib_dir/libmlir_async_runtime%shlibext \
// _UN: -shared-libs=%linalg_test_lib_dir/libmlir_runner_utils%shlibext \ // RUN: | FileCheck %s
// _UN: -shared-libs=%linalg_test_lib_dir/libmlir_async_runtime%shlibext \
// _UN: | FileCheck %s
func @main() { func @main() {
%group = async.create_group %group = async.create_group
%token0 = async.execute { async.yield } %token0 = async.execute { async.yield }
%token1 = async.execute { async.yield } %token1 = async.execute { async.yield }
%token2 = async.execute { async.yield } %token2 = async.execute { async.yield }
%token3 = async.execute { async.yield } %token3 = async.execute { async.yield }
Show All 24 Lines

mlir/test/mlir-cpu-runner/async.mlir

// RUN: true // RUN: mlir-opt %s -async-ref-counting \
// TODO: re-enable when not flaky. // RUN: -convert-async-to-llvm \
// _UN: mlir-opt %s -async-ref-counting \ // RUN: -convert-linalg-to-loops \
// _UN: -convert-async-to-llvm \ // RUN: -convert-linalg-to-llvm \
// _UN: -convert-linalg-to-loops \ // RUN: -convert-std-to-llvm \
// _UN: -convert-linalg-to-llvm \ // RUN: | mlir-cpu-runner \
// _UN: -convert-std-to-llvm \ // RUN: -e main -entry-point-result=void -O0 \
// _UN: | mlir-cpu-runner \ // RUN: -shared-libs=%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext \
// _UN: -e main -entry-point-result=void -O0 \ // RUN: -shared-libs=%linalg_test_lib_dir/libmlir_runner_utils%shlibext \
// _UN: -shared-libs=%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext \ // RUN: -shared-libs=%linalg_test_lib_dir/libmlir_async_runtime%shlibext \
// _UN: -shared-libs=%linalg_test_lib_dir/libmlir_runner_utils%shlibext \ // RUN: | FileCheck %s
// _UN: -shared-libs=%linalg_test_lib_dir/libmlir_async_runtime%shlibext \
// _UN: | FileCheck %s
func @main() { func @main() {
%i0 = constant 0 : index %i0 = constant 0 : index
%i1 = constant 1 : index %i1 = constant 1 : index
%i2 = constant 2 : index %i2 = constant 2 : index
%i3 = constant 3 : index %i3 = constant 3 : index
%c0 = constant 0.0 : f32 %c0 = constant 0.0 : f32
▲ Show 20 Lines • Show All 66 Lines • Show Last 20 Lines