This is an archive of the discontinued LLVM Phabricator instance.

Differential D93198

[compiler-rt][CMake] Define HAS_ASM_LSE on Apple if available
ClosedPublic

Authored by tambre on Dec 14 2020, 1:26 AM.

Details

Reviewers
ilinpv
Commits
rGd9697c2e6b15: [compiler-rt][CMake] Define HAS_ASM_LSE on Apple if available
Summary

Should hopefully fix 33b740f8dc3496237619a7bc6722f23655cb1f94 (D93178) failing on bots.

Diff Detail

Unit TestsFailed

TimeTest
60 msx64 windows > LLVM.CodeGen/XCore::threads.ll

Event Timeline

tambre created this revision.Dec 14 2020, 1:26 AM
Herald added subscribers: mgorny, dberris. · View Herald TranscriptDec 14 2020, 1:26 AM
tambre requested review of this revision.Dec 14 2020, 1:26 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 14 2020, 1:26 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2020, 1:26 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGd9697c2e6b15: [compiler-rt][CMake] Define HAS_ASM_LSE on Apple if available (authored by tambre). · Explain Why
This revision was automatically updated to reflect the committed changes.
tambre added a commit: rGd9697c2e6b15: [compiler-rt][CMake] Define HAS_ASM_LSE on Apple if available.
tambre added a reverting change: D93199: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".Dec 14 2020, 1:42 AM
tambre added a reverting change: rG617cd01a4b7a: Revert "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins….Dec 14 2020, 1:42 AM
Harbormaster completed remote builds in B82234: Diff 311518.Dec 14 2020, 1:52 AM
tambre mentioned this in D93211: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".Dec 14 2020, 6:43 AM
tambre mentioned this in rGd0797e62fa8a: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins….Dec 14 2020, 6:45 AM
tambre mentioned this in D93278: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins separately".Dec 14 2020, 10:17 PM
tambre mentioned this in rGa72d462eb9b9: Re-apply "[CMake][compiler-rt][AArch64] Avoid preprocessing LSE builtins….Dec 14 2020, 10:18 PM

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
4 lines

Diff 311518

compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake

Show First 20 Lines • Show All 389 Lines • ▼ Show 20 Lines
macro(darwin_add_builtin_libraries) macro(darwin_add_builtin_libraries)
set(DARWIN_EXCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/Darwin-excludes) set(DARWIN_EXCLUDE_DIR ${CMAKE_CURRENT_SOURCE_DIR}/Darwin-excludes)
set(CFLAGS "-fPIC -O3 -fvisibility=hidden -DVISIBILITY_HIDDEN -Wall -fomit-frame-pointer") set(CFLAGS "-fPIC -O3 -fvisibility=hidden -DVISIBILITY_HIDDEN -Wall -fomit-frame-pointer")
set(CMAKE_C_FLAGS "") set(CMAKE_C_FLAGS "")
set(CMAKE_CXX_FLAGS "") set(CMAKE_CXX_FLAGS "")
set(CMAKE_ASM_FLAGS "") set(CMAKE_ASM_FLAGS "")
append_string_if(COMPILER_RT_HAS_ASM_LSE " -DHAS_ASM_LSE" CFLAGS)
set(PROFILE_SOURCES ../profile/InstrProfiling set(PROFILE_SOURCES ../profile/InstrProfiling
../profile/InstrProfilingBuffer ../profile/InstrProfilingBuffer
../profile/InstrProfilingPlatformDarwin ../profile/InstrProfilingPlatformDarwin
../profile/InstrProfilingWriter ../profile/InstrProfilingWriter
../profile/InstrProfilingInternal ../profile/InstrProfilingInternal
../profile/InstrProfilingVersionVar) ../profile/InstrProfilingVersionVar)
foreach (os ${ARGN}) foreach (os ${ARGN})
list_intersect(DARWIN_BUILTIN_ARCHS DARWIN_${os}_BUILTIN_ARCHS BUILTIN_SUPPORTED_ARCH) list_intersect(DARWIN_BUILTIN_ARCHS DARWIN_${os}_BUILTIN_ARCHS BUILTIN_SUPPORTED_ARCH)
foreach (arch ${DARWIN_BUILTIN_ARCHS}) foreach (arch ${DARWIN_BUILTIN_ARCHS})
▲ Show 20 Lines • Show All 164 Lines • Show Last 20 Lines