Page MenuHomePhabricator

[X86] Avoid data16 prefix for lea in x32 mode
ClosedPublic

Authored by hvdijk on Dec 12 2020, 4:33 AM.

Details

Summary

The ABI demands a data16 prefix for lea in 64-bit LP64 mode, but not in
64-bit ILP32 mode. In both modes this prefix would ordinarily be
ignored, but the instructions may be changed by the linker to
instructions that are affected by the prefix.

Diff Detail

Event Timeline

hvdijk created this revision.Dec 12 2020, 4:33 AM
hvdijk requested review of this revision.Dec 12 2020, 4:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 12 2020, 4:33 AM
RKSimon accepted this revision.Dec 12 2020, 8:33 AM

LGTM

This revision is now accepted and ready to land.Dec 12 2020, 8:33 AM
This revision was landed with ongoing or failed builds.Dec 12 2020, 9:05 AM
This revision was automatically updated to reflect the committed changes.