Make debug dump more friendly to conditional debug compilation

[mtrofin]

Instead of this change, have you tried building the binary with -DLLVM_ENABLE_DUMP

[gjain]

@mtrofin: Thanks that works. That being said do you think that's a suitable necessity for the entire binary? Seems like all those dump functions don't really need to be included in the binary.

[mtrofin]

In D93139#2450141, @gjain wrote:

@mtrofin: Thanks that works. That being said do you think that's a suitable necessity for the entire binary? Seems like all those dump functions don't really need to be included in the binary.

Not sure what the concern is - I think the facility is for debugging purposes only, i.e. not something meant to survive in the release compiler.

llvm/lib/CodeGen/RegAllocFast.cpp

for (MachineInstr *DbgValue : UDBGPair.second) {
         continue;
       LLVM_DEBUG(dbgs() << "Register did not survive for " << *DbgValue
                  << '\n');
       MO.setReg(0);
     }
   }
   DanglingDbgValues.clear();
 
-  LLVM_DEBUG(MBB.dump());
+  LLVM_DEBUG(MBB.print(dbgs()));
 }
 
 bool RegAllocFast::runOnMachineFunction(MachineFunction &MF) {
   LLVM_DEBUG(dbgs() << "********** FAST REGISTER ALLOCATION **********\n"
                     << "********** Function: " << MF.getName() << '\n');
   MRI = &MF.getRegInfo();
   const TargetSubtargetInfo &STI = MF.getSubtarget();
   TRI = STI.getRegisterInfo();

llvm/lib/CodeGen/RegAllocGreedy.cpp

bool RAGreedy::runOnMachineFunction(MachineFunction &mf) {
   AA = &getAnalysis<AAResultsWrapperPass>().getAAResults();
 
   initializeCSRCost();
 
   VRAI = std::make_unique<VirtRegAuxInfo>(*MF, *LIS, *VRM, *Loops, *MBFI);
 
   VRAI->calculateSpillWeightsAndHints();
 
-  LLVM_DEBUG(LIS->dump());
+  LLVM_DEBUG(LIS->print(dbgs()));
 
   SA.reset(new SplitAnalysis(*VRM, *LIS, *Loops));
   SE.reset(new SplitEditor(*SA, *AA, *LIS, *VRM, *DomTree, *MBFI));
   ExtraRegInfo.clear();
   ExtraRegInfo.resize(MRI->getNumVirtRegs());
   NextCascade = 1;
   IntfCache.init(MF, Matrix->getLiveUnions(), Indexes, LIS, TRI);
   GlobalCand.resize(32);  // This will grow as needed.

llvm/lib/Target/AArch64/AArch64PBQPRegAlloc.cpp

static bool regJustKilledBefore(const LiveIntervals &LIs, unsigned reg,
   return LI.expiredAt(SI);
 }
 
 void A57ChainingConstraint::apply(PBQPRAGraph &G) {
   const MachineFunction &MF = G.getMetadata().MF;
   LiveIntervals &LIs = G.getMetadata().LIS;
 
   TRI = MF.getSubtarget().getRegisterInfo();
-  LLVM_DEBUG(MF.dump());
+  LLVM_DEBUG(MF.print(dbgs()));
 
   for (const auto &MBB: MF) {
     Chains.clear(); // FIXME: really needed ? Could not work at MF level ?
 
     for (const auto &MI: MBB) {
 
       // Forget Chains which have expired
       for (auto r : Chains) {