Followup to D87604, having confirmed on PR47506 that we can use the llvm codegen expansion for fadd/fmul as well.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Time | Test | |
---|---|---|
60 ms | x64 windows > LLVM.CodeGen/XCore::threads.ll |
Event Timeline
LGTM. Thanks for bringing this refactor.
I also verified that ICC and GCC both do reduce math in an binary tree way, though sometimes ICC has a different LSB from GCC and Clang.
clang/lib/Headers/avx512fintrin.h | ||
---|---|---|
9559 | Better to change min and max as well. |
clang/lib/Headers/avx512fintrin.h | ||
---|---|---|
9559 | OK - I'll do that as a followup immediately after this patch - thanks! |
clang-tidy: error: "Never use <avx512fintrin.h> directly; include <immintrin.h> instead." [clang-diagnostic-error]
not useful