This is an archive of the discontinued LLVM Phabricator instance.

Differential D92937

[libc++] Run back-deployment CI on macOS 10.15 instead of 10.14
ClosedPublic

Authored by ldionne on Dec 9 2020, 6:59 AM.

Details

Reviewers
curdeius
Group Reviewers
Restricted Project
Commits
rG717b0da7a6ef: [libc++] Run back-deployment CI on macOS 10.15 instead of 10.14
Summary

The goal was to add coverage for back-deployment over the filesystem
library, but it was added in macOS 10.15, not 10.14.

Diff Detail

Event Timeline

ldionne created this revision.Dec 9 2020, 6:59 AM
Herald added subscribers: jkorous, arichardson. · View Herald TranscriptDec 9 2020, 6:59 AM
ldionne requested review of this revision.Dec 9 2020, 6:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 9 2020, 6:59 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne mentioned this in D92769: [libc++] [P1164] [C++20] Make fs::create_directory() error if there is already a non-directory..Dec 9 2020, 7:00 AM
Harbormaster completed remote builds in B81629: Diff 310517.Dec 9 2020, 8:06 AM
curdeius added a child revision: D92769: [libc++] [P1164] [C++20] Make fs::create_directory() error if there is already a non-directory..Dec 9 2020, 8:09 AM
curdeius accepted this revision.Dec 9 2020, 8:13 AM

I've added this revision as a parent of D92769 and rebased to trigger CI. Hopefully it will error on this new config. You might want to wait for CI to finish to verify it really fails.

ldionne accepted this revision as: Restricted Project.Dec 9 2020, 8:21 AM
This revision is now accepted and ready to land.Dec 9 2020, 8:21 AM
Closed by commit rG717b0da7a6ef: [libc++] Run back-deployment CI on macOS 10.15 instead of 10.14 (authored by ldionne). · Explain WhyDec 9 2020, 8:35 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG717b0da7a6ef: [libc++] Run back-deployment CI on macOS 10.15 instead of 10.14.

Revision Contents

PathSize
libcxx/
utils/
ci/
4 lines

Diff 310517

libcxx/utils/ci/buildkite-pipeline.yml

Show First 20 Lines • Show All 270 Lines • ▼ Show 20 Lines artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
agents: agents:
queue: "libcxx-macos-builders" queue: "libcxx-macos-builders"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
- label: "Apple back-deployment macosx10.14" - label: "Apple back-deployment macosx10.15"
command: "libcxx/utils/ci/run-buildbot x86_64-apple-system-backdeployment-10.14" command: "libcxx/utils/ci/run-buildbot x86_64-apple-system-backdeployment-10.15"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
agents: agents:
queue: "libcxx-macos-builders" queue: "libcxx-macos-builders"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2