This is an archive of the discontinued LLVM Phabricator instance.

Differential D92794

[libc++] Add a CI job to backdeploy to macOS 10.14
ClosedPublic

Authored by ldionne on Dec 7 2020, 3:23 PM.

Details

Reviewers
curdeius
Group Reviewers
Restricted Project
Commits
rG8726f94cc74f: [libc++] Add a CI job to backdeploy to macOS 10.14
Summary

It adds coverage for back-deploying to a system that contains the
filesystem library, which 10.9 (currently our only back-deployment
target in the CI) does not have.

Diff Detail

Event Timeline

ldionne created this revision.Dec 7 2020, 3:23 PM
Herald added subscribers: jkorous, arichardson. · View Herald TranscriptDec 7 2020, 3:23 PM
ldionne requested review of this revision.Dec 7 2020, 3:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2020, 3:23 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne mentioned this in D92769: [libc++] [P1164] [C++20] Make fs::create_directory() error if there is already a non-directory..Dec 7 2020, 3:26 PM
Harbormaster completed remote builds in B81363: Diff 310038.Dec 7 2020, 4:22 PM
curdeius accepted this revision.Dec 7 2020, 11:41 PM
curdeius added a child revision: D92769: [libc++] [P1164] [C++20] Make fs::create_directory() error if there is already a non-directory..
curdeius added a subscriber: curdeius.

LGTM 👍

ldionne accepted this revision as: Restricted Project.Dec 8 2020, 8:07 AM
This revision is now accepted and ready to land.Dec 8 2020, 8:07 AM
Closed by commit rG8726f94cc74f: [libc++] Add a CI job to backdeploy to macOS 10.14 (authored by ldionne). · Explain WhyDec 8 2020, 8:08 AM
This revision was automatically updated to reflect the committed changes.
ldionne added a commit: rG8726f94cc74f: [libc++] Add a CI job to backdeploy to macOS 10.14.

Revision Contents

PathSize
libcxx/
utils/
ci/
11 lines

Diff 310224

libcxx/utils/ci/buildkite-pipeline.yml

Show First 20 Lines • Show All 269 Lines • ▼ Show 20 Lines - label: "Apple back-deployment macosx10.9"
artifact_paths: artifact_paths:
- "**/test-results.xml" - "**/test-results.xml"
agents: agents:
queue: "libcxx-macos-builders" queue: "libcxx-macos-builders"
retry: retry:
automatic: automatic:
- exit_status: -1 # Agent was lost - exit_status: -1 # Agent was lost
limit: 2 limit: 2
- label: "Apple back-deployment macosx10.14"
command: "libcxx/utils/ci/run-buildbot x86_64-apple-system-backdeployment-10.14"
artifact_paths:
- "**/test-results.xml"
agents:
queue: "libcxx-macos-builders"
retry:
automatic:
- exit_status: -1 # Agent was lost
limit: 2