Replace 'master' with 'main' in instructions on how to create and push patches.
Details
Diff Detail
Event Timeline
Thanks for this.
The proposed changes all LGTM.
I did do a grep on the term 'master' in llvm/docs, and found quite a few more uses of 'master', especially in links.
The command I used was: grep -R master llvm/docs/
Just two examples are:
llvm/docs/CodingStandards.rst:<https://github.com/llvm/llvm-project/tree/master/llvm/include/llvm/ADT>`_) llvm/docs/GitBisecting.rst:being able to reset, do the usual ``git checkout -f master; git reset --hard
Would you also be willing to adapt/fix the URLs pointing to llvm-project in that directory?
Thanks,
Kristof
Updated other instances in llvm/docs. I have initially updated the whole tree but that becomes quite a big patch. I can post that one if it is of interest.
llvm/docs/CompileCudaWithLLVM.rst | ||
---|---|---|
147 | For the llvm-test-suite project (rather than the llvm-project project), there is no main branch yet. @sqlbyme did you have a timeline for when you'd expect to also add a main branch in llvm-test-suite. |
llvm/docs/CompileCudaWithLLVM.rst | ||
---|---|---|
147 | Thanks for catching this. It was an oversight. I will remove it from the patch as there are other locations which refers https://github.com/llvm/llvm-test-suite which I had not touched. We can update them when they have a main branch of their own. |
For the llvm-test-suite project (rather than the llvm-project project), there is no main branch yet.
So if we'd commit this as is, that would break the link.
@sqlbyme did you have a timeline for when you'd expect to also add a main branch in llvm-test-suite.
If that is expected to happen soon, maybe it's simplest to just wait for that to happen and then commit this patch as a whole?