[clang-tidy] Recognize single character needles for absl::StrContains.
ClosedPublic
Actions

Authored by ckennelly on Dec 7 2020, 8:31 PM.

Details

Reviewers

EricWF
ymandel
hokein

Commits

rG16622d535c02: [clang-tidy] Recognize single character needles for absl::StrContains.

Summary

Commit fbdff6f3ae0b in the Abseil tree adds an overload for
absl::StrContains to accept a single character needle for optimized
lookups.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ckennelly created this revision.Dec 7 2020, 8:31 PM

Herald added a subscriber: xazax.hun. · View Herald TranscriptDec 7 2020, 8:31 PM

ckennelly requested review of this revision.Dec 7 2020, 8:31 PM

Herald added a project: Restricted Project. · View Herald TranscriptDec 7 2020, 8:31 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B81391: Diff 310081.Dec 7 2020, 9:11 PM

hokein accepted this revision.Dec 8 2020, 12:05 AM

This revision is now accepted and ready to land.Dec 8 2020, 12:05 AM

This revision was landed with ongoing or failed builds.Dec 8 2020, 7:01 AM

Closed by commit rG16622d535c02: [clang-tidy] Recognize single character needles for absl::StrContains. (authored by ckennelly). · Explain Why

This revision was automatically updated to reflect the committed changes.

ckennelly added a commit: rG16622d535c02: [clang-tidy] Recognize single character needles for absl::StrContains..

Revision Contents
Changeset List

Path

Size

clang-tools-extra/

clang-tidy/

abseil/

StringFindStrContainsCheck.cpp

8 lines

test/

clang-tidy/

checkers/

abseil-string-find-str-contains.cpp

10 lines

Diff 310183

View Options

clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp