Page MenuHomePhabricator

ckennelly (Chris Kennelly)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 4 2018, 4:06 PM (89 w, 23 h)

Recent Activity

May 8 2019

ckennelly added a comment to D59999: Allow the compiler to optimize `string == "literal string"`..

I can go through the char_traits, but char_traits::compare() has an extra branch that is unnecessary here. compare checks that the size is not 0, which is useful to avoid calling memcmp with null pointers. But there is no possiblity of null pointers here. The .data() will never return null, and the char* can't be null either (there is an assertion for that, and we passed it to strlen).

May 8 2019, 11:32 AM · Restricted Project

Jan 18 2019

ckennelly added a comment to D55741: Implementation Feature Test Macros for P0722R3.

I'd be happy to restrict this to > C++17 only (which is automatically the case when using G++ because there's no -fdestroying-delete to enable it, you only get it with -std=c++2a, -std=gnu++2a etc.)

Jan 18 2019, 4:32 PM · Restricted Project

Jan 16 2019

ckennelly added a comment to D55741: Implementation Feature Test Macros for P0722R3.

Conditioning off of C++17 (or part C++11 and part C++17) seems reasonable, although we may want consistency with libc++ (discussion on https://reviews.llvm.org/D55840).

Jan 16 2019, 5:21 PM · Restricted Project

Jan 11 2019

ckennelly added a comment to D55840: P0722R3: Implement library support for destroying delete.

Another question - why do we need to check if clang supports destroying delete to define the type destroying_delete_t? Why not define it always, and just define the feature test macro when we have compiler support?

I'm not a big fan of this approach. It seems better to define __cpp_lib_destroying_delete if and only if we provide destroying_delete_t, which makes sense if and only if the compiler has support for it (i.e. __cpp_impl_destroying_delete is defined).

Jan 11 2019, 9:35 AM
ckennelly committed rL350934: Implementation Feature Test Macros for P0722R3.
Implementation Feature Test Macros for P0722R3
Jan 11 2019, 9:13 AM
ckennelly committed rC350934: Implementation Feature Test Macros for P0722R3.
Implementation Feature Test Macros for P0722R3
Jan 11 2019, 9:13 AM
ckennelly closed D55741: Implementation Feature Test Macros for P0722R3.
Jan 11 2019, 9:13 AM · Restricted Project

Jan 7 2019

ckennelly committed rL350605: [NFC] Remove empty line as a test commit..
[NFC] Remove empty line as a test commit.
Jan 7 2019, 8:08 PM

Dec 18 2018

ckennelly created D55840: P0722R3: Implement library support for destroying delete.
Dec 18 2018, 10:52 AM

Dec 17 2018

ckennelly added a comment to D55741: Implementation Feature Test Macros for P0722R3.

Yes, I need someone to commit for me.

Dec 17 2018, 6:16 AM · Restricted Project

Dec 16 2018

ckennelly updated the diff for D55741: Implementation Feature Test Macros for P0722R3.

Added update to cxx_status.html for partial implementation of feature test macros adopted in San Diego

Dec 16 2018, 9:34 PM · Restricted Project

Dec 15 2018

ckennelly created D55741: Implementation Feature Test Macros for P0722R3.
Dec 15 2018, 9:04 PM · Restricted Project

Oct 11 2018

ckennelly added inline comments to D53120: Implement sized deallocation for std::allocator and friends..
Oct 11 2018, 9:16 AM

Jan 18 2018

ckennelly added a comment to D41746: Make std::get_temporary_buffer respect overaligned types when possible.

I don't have commit access, so can this be committed to trunk?

Jan 18 2018, 1:11 PM

Jan 12 2018

ckennelly added a comment to D41746: Make std::get_temporary_buffer respect overaligned types when possible.

This LGTM minus nits.

Is there a LWG issue or paper that specifies this change? or is it just a general bug fix?

Jan 12 2018, 1:32 PM
ckennelly updated the diff for D41746: Make std::get_temporary_buffer respect overaligned types when possible.
Jan 12 2018, 1:28 PM

Jan 4 2018

ckennelly created D41746: Make std::get_temporary_buffer respect overaligned types when possible.
Jan 4 2018, 4:33 PM