[GWP-ASan] IWYU & clang-format

[hctim]

Summary

Run an IWYU pass and clang-format GWP-ASan code.

[hctim]

(wrong basis point)

[mcgrathr]

compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp

12 ↗

(On Diff #309649)

sys/syscall.h -> syscall.h may be an unintended change.
With (Linux) glibc they are exactly the same, but IIRC <sys/syscall.h> is the traditional name and I'm not sure if BSD has (or has always had) both.

[eugenis]

LGTM with nit

compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp

12 ↗

(On Diff #309649)

Yes, that's strange, is it a change from iwui, clang-format, or manual?

[hctim]

compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp

12 ↗

(On Diff #309649)

IWYU made the change:

/usr/local/google/home/mitchp/llvm/compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp should add these lines:
#include <syscall.h>          // for SYS_gettid

/usr/local/google/home/mitchp/llvm/compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp should remove these lines:
- #include <sys/syscall.h>  // lines 12-12

The full include-list for /usr/local/google/home/mitchp/llvm/compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp:
#include <stdint.h>           // for uint64_t
#include <syscall.h>          // for SYS_gettid
#include <unistd.h>           // for syscall
#include "gwp_asan/common.h"  // for getThreadID
---

I'm inclined to go with "whatever will make me not have to remember that IWYU hates this include" solution (which is syscall.h), unless we can think of anything that will break. LMK :).

[hctim]

compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp

12 ↗

(On Diff #309649)

(@eugenis - still LGTY?)

[eugenis]

compiler-rt/lib/gwp_asan/platform_specific/common_posix.cpp

12 ↗

(On Diff #309649)

I'd rather keep <sys/syscall.h> with an IWYU pragma.

[hctim]

• Switch back to sys/syscall.h and add related pragmas.

compiler-rt/lib/gwp_asan/crash_handler.cpp

 //===-- crash_handler.cpp ---------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #include "gwp_asan/common.h"
 #include "gwp_asan/stack_trace_compressor.h"
 
 #include <assert.h>
-#include <string.h>
 #include <stdint.h>
+#include <string.h>
 
 using AllocationMetadata = gwp_asan::AllocationMetadata;
 using Error = gwp_asan::Error;
 
 #ifdef __cplusplus
 extern "C" {
 #endif
 

compiler-rt/lib/gwp_asan/mutex.h

 //===-- mutex.h -------------------------------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
 #ifndef GWP_ASAN_MUTEX_H_
 #define GWP_ASAN_MUTEX_H_
 
 #include "gwp_asan/platform_specific/mutex_fuchsia.h" // IWYU pragma: keep
-#include "gwp_asan/platform_specific/mutex_posix.h" // IWYU pragma: keep
+#include "gwp_asan/platform_specific/mutex_posix.h"   // IWYU pragma: keep
 
 namespace gwp_asan {
 class Mutex final : PlatformMutex {
 public:
   constexpr Mutex() = default;
   ~Mutex() = default;
   Mutex(const Mutex &) = delete;
   Mutex &operator=(const Mutex &) = delete;

compiler-rt/lib/gwp_asan/platform_specific/guarded_pool_allocator_posix.cpp

 //===-- guarded_pool_allocator_posix.cpp ------------------------*- C++ -*-===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 
-#include "gwp_asan/guarded_pool_allocator.h"
-#include "gwp_asan/utilities.h"
 #include "gwp_asan/common.h"
+#include "gwp_asan/guarded_pool_allocator.h"
 #include "gwp_asan/platform_specific/guarded_pool_allocator_tls.h"
+#include "gwp_asan/utilities.h"
 
 #include <assert.h>
+#include <pthread.h>
+#include <stdint.h>
 #include <stdlib.h>
 #include <sys/mman.h>
 #include <time.h>
 #include <unistd.h>
-#include <pthread.h>
-#include <stdint.h>
 
 #ifdef ANDROID
 #include <sys/prctl.h>
 #define PR_SET_VMA 0x53564d41
 #define PR_SET_VMA_ANON_NAME 0
 #endif // ANDROID
 
 namespace {