This is an archive of the discontinued LLVM Phabricator instance.

Differential D92597

ARCMigrate: Initialize fields in EditEntry inline, NFC
ClosedPublic

Authored by dexonsmith on Dec 3 2020, 12:09 PM.

Details

Reviewers
jansvoboda11
JDevlieghere
akyrtzi
Commits
rG9ae0a46f2bbf: ARCMigrate: Initialize fields in EditEntry inline, NFC
Summary

Initialize the fields inline instead of having to manually write out a
default constructor.

Diff Detail

Event Timeline

dexonsmith created this revision.Dec 3 2020, 12:09 PM
Herald added a subscriber: ributzka. · View Herald TranscriptDec 3 2020, 12:09 PM
dexonsmith requested review of this revision.Dec 3 2020, 12:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 12:09 PM
JDevlieghere accepted this revision.Dec 3 2020, 1:17 PM
This revision is now accepted and ready to land.Dec 3 2020, 1:17 PM
JDevlieghere added a comment.Dec 3 2020, 1:17 PM

LGTM

Harbormaster completed remote builds in B80998: Diff 309330.Dec 3 2020, 1:32 PM
Closed by commit rG9ae0a46f2bbf: ARCMigrate: Initialize fields in EditEntry inline, NFC (authored by dexonsmith). · Explain WhyDec 4 2020, 2:45 PM
This revision was automatically updated to reflect the committed changes.
dexonsmith added a commit: rG9ae0a46f2bbf: ARCMigrate: Initialize fields in EditEntry inline, NFC.

Revision Contents

PathSize
clang/
lib/
ARCMigrate/
8 lines

Diff 309330

clang/lib/ARCMigrate/ObjCMT.cpp

Show First 20 Lines • Show All 2,028 Lines • ▼ Show 20 LinesMigrateSourceAction::CreateASTConsumer(CompilerInstance &CI, StringRef InFile) {
return std::make_unique<ObjCMigrateASTConsumer>( return std::make_unique<ObjCMigrateASTConsumer>(
CI.getFrontendOpts().OutputFile, ObjCMTAction, Remapper, CI.getFrontendOpts().OutputFile, ObjCMTAction, Remapper,
CI.getFileManager(), PPRec, CI.getPreprocessor(), CI.getFileManager(), PPRec, CI.getPreprocessor(),
/*isOutputFile=*/true, WhiteList); /*isOutputFile=*/true, WhiteList);
} }
namespace { namespace {
struct EditEntry { struct EditEntry {
const FileEntry *File; const FileEntry *File = nullptr;
unsigned Offset; unsigned Offset = 0;
unsigned RemoveLen; unsigned RemoveLen = 0;
std::string Text; std::string Text;
EditEntry() : File(), Offset(), RemoveLen() {}
}; };
} // end anonymous namespace } // end anonymous namespace
namespace llvm { namespace llvm {
template<> struct DenseMapInfo<EditEntry> { template<> struct DenseMapInfo<EditEntry> {
static inline EditEntry getEmptyKey() { static inline EditEntry getEmptyKey() {
EditEntry Entry; EditEntry Entry;
Entry.Offset = unsigned(-1); Entry.Offset = unsigned(-1);
▲ Show 20 Lines • Show All 226 Lines • Show Last 20 Lines