To build toy.cpp we need ORCJIT instead of MCJIT library. Some links are broken by having .html extension instead of .rst. CFG image' merge block in fifth chapter return %iftmp instead of %0 (Tested on llvm-12.0git).
Provide three blog post links for Examples/MCJIT directory. (Though MCJIT examples are unmaintained/outdated so MCJIT/../toy.cpp are not building).
Details
- Reviewers
SjoerdMeijer fhahn lhames
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
@lhames could you take a quick look at the orcjit related changes?
llvm/docs/tutorial/LangImpl01.rst | ||
---|---|---|
7 | This won't work I think, because this will treat it as external link. I think you can use the :doc: directive to reference internal pages, like :doc:`MyFirstLanguageFrontend/index | |
llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05.rst | ||
359 | While you are here, we could just update those links to use internal references. Something like the code below should do it. :ref:`requires all basic blocks to be "terminated" <functionstructure>` and :ref:`control flow instruction <terminators>` |
Update to address comments.
Don't know why 'arc patch D92588' doesn't successful because of cfg image and gives an error "error: the patch applies to 'llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05-cfg.png' (cdba92ff6c5c95b142bd928971bcdd560117028c), which does not match the current contents"? (image is now removed).
Thanks, @lhames for reviewing! If it is fine please commit on my behalf, I don't have commit access. ( email address- shivam98.tkg@gmail.com & githubid- xgupta)
I abandon the review at that time because I am not an active dev to work on changes if proposed.
This won't work I think, because this will treat it as external link.
I think you can use the :doc: directive to reference internal pages, like