This is an archive of the discontinued LLVM Phabricator instance.

[Doc][NFC] Fix Kaleidoscope links, typos and add blog posts for MCJIT
AbandonedPublic

Authored by xgupta on Dec 3 2020, 10:25 AM.

Details

Summary

To build toy.cpp we need ORCJIT instead of MCJIT library. Some links are broken by having .html extension instead of .rst. CFG image' merge block in fifth chapter return %iftmp instead of %0 (Tested on llvm-12.0git).
Provide three blog post links for Examples/MCJIT directory. (Though MCJIT examples are unmaintained/outdated so MCJIT/../toy.cpp are not building).

Diff Detail

Event Timeline

xgupta created this revision.Dec 3 2020, 10:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2020, 10:25 AM
xgupta requested review of this revision.Dec 3 2020, 10:25 AM
xgupta retitled this revision from [Doc][NFC] Fix Kaleidoscope links, typos and cfg image. to [Doc][NFC] Fix Kaleidoscope links, typos, cfg image and add blog posts for MCJIT.Dec 3 2020, 10:30 AM
xgupta edited the summary of this revision. (Show Details)
fhahn added a reviewer: lhames.Dec 4 2020, 9:11 AM
fhahn added a subscriber: lhames.

@lhames could you take a quick look at the orcjit related changes?

llvm/docs/tutorial/LangImpl01.rst
7

This won't work I think, because this will treat it as external link.

I think you can use the :doc: directive to reference internal pages, like

:doc:`MyFirstLanguageFrontend/index
llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05.rst
359

While you are here, we could just update those links to use internal references. Something like the code below should do it.

:ref:`requires all basic blocks to be "terminated" <functionstructure>`

and

:ref:`control flow instruction <terminators>`
fhahn added a comment.Dec 4 2020, 9:11 AM

Thank you very much for working on improving the docs!

xgupta updated this revision to Diff 309720.Dec 5 2020, 1:04 AM

Update to address comments.

Don't know why 'arc patch D92588' doesn't successful because of cfg image and gives an error "error: the patch applies to 'llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05-cfg.png' (cdba92ff6c5c95b142bd928971bcdd560117028c), which does not match the current contents"? (image is now removed).

xgupta abandoned this revision.Dec 11 2020, 10:56 AM
xgupta marked 2 inline comments as done.

@fhahn @xgupta Apologies for the delayed reply. I'm not sure why this was abandoned -- it looks good to me.

xgupta reclaimed this revision.Jan 20 2021, 9:06 AM

Thanks, @lhames for reviewing! If it is fine please commit on my behalf, I don't have commit access. ( email address- shivam98.tkg@gmail.com & githubid- xgupta)
I abandon the review at that time because I am not an active dev to work on changes if proposed.

xgupta retitled this revision from [Doc][NFC] Fix Kaleidoscope links, typos, cfg image and add blog posts for MCJIT to [Doc][NFC] Fix Kaleidoscope links, typos and add blog posts for MCJIT.Jan 24 2021, 8:05 AM