Page MenuHomePhabricator

ADT: Remove AlignedCharArrayUnion, NFC
ClosedPublic

Authored by dexonsmith on Dec 2 2020, 3:49 PM.

Details

Summary

Prep commit already migrated users over to std::aligned_union_t; this
just deletes the type / header / test.

Diff Detail

Event Timeline

dexonsmith created this revision.Dec 2 2020, 3:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 2 2020, 3:49 PM
Herald added a subscriber: ributzka. · View Herald Transcript
dblaikie accepted this revision.Dec 2 2020, 3:56 PM

Sounds good.

(Funny the history of names - AlignOf.h used to contain a device for finding the alignment of a thing - now that thing no longer exists (replaced by the standard alignas) but the header migrated through various alignment related tools to where it is now... )

This revision is now accepted and ready to land.Dec 2 2020, 3:56 PM

Sounds good.

(Funny the history of names - AlignOf.h used to contain a device for finding the alignment of a thing - now that thing no longer exists (replaced by the standard alignas) but the header migrated through various alignment related tools to where it is now... )

Thanks for the reviews! (this and the others); I'll hold off committing this and others until tomorrow at least to give unexpected bots time to process https://reviews.llvm.org/D92500 (I think that's the only risky one...).

Apparently I didn't build this before; I'd forgotten to delete the line from CMakeLists.txt; may as well get the try bots to build before pushing.

This revision was automatically updated to reflect the committed changes.