Since the length of the llvm::SmallVector shufflemask is related to the
minimum number of elements in a scalable vector, it is fine to just get
the Min field of the ElementCount. This is already done for the similar
function changesLength, tests have been added for both.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
LGTM
llvm/unittests/IR/InstructionsTest.cpp | ||
---|---|---|
1095 | Nothing to change in this patch, but I just thought this interface had been removed so that it would take an ArrayRef instead of a Constant? |
llvm/unittests/IR/InstructionsTest.cpp | ||
---|---|---|
1095 |
There's two interfaces where Mask can be either an llvm::Value or ArrayRef<int>, I think most of these tests are using the former interface since they pass an llvm::Constant |
Nothing to change in this patch, but I just thought this interface had been removed so that it would take an ArrayRef instead of a Constant?