This is an archive of the discontinued LLVM Phabricator instance.

Differential D9246

[ASan][MIPS] Fix some tests failing on MIPS64
ClosedPublic

Authored by slthakur on Apr 24 2015, 2:57 AM.

Details

Reviewers
kcc
dsanders
samsonov
Commits
rG26f165b04e80: [ASan][MIPS] Fix null_deref.cc test on MIPS64
rCRT236572: [ASan][MIPS] Fix null_deref.cc test on MIPS64
rL236572: [ASan][MIPS] Fix null_deref.cc test on MIPS64
Summary

Tests fixed:

AddressSanitizer-mips64-linux :: TestCases/null_deref.cc: symbol for pc was wrong.
AddressSanitizer-mips64-linux :: TestCases/Linux/quarantine_size_mb.cc : The flag quarantine_size_mb should not be compared for >=0 as it is defined as u32 type.

Diff Detail

Repository
rL LLVM

Event Timeline

slthakur updated this revision to Diff 24368.Apr 24 2015, 2:57 AM
slthakur retitled this revision from to [ASan][MIPS] Fix some tests failing on MIPS64.
slthakur updated this object.
slthakur edited the test plan for this revision. (Show Details)
slthakur added reviewers: dsanders, kcc, samsonov.
slthakur set the repository for this revision to rL LLVM.
slthakur added subscribers: jaydeep, mohit.bhakkad, Unknown Object (MLST).
samsonov added inline comments.Apr 24 2015, 11:21 AM
lib/asan/asan_flags.cc
157 ↗(On Diff #24368)

No. This quarantinze_size_mb is defined in asan_flags.inc and has type int.

lib/sanitizer_common/sanitizer_linux.cc
1001 ↗(On Diff #24368)

This change is OK. Feel free to commit it in a separate change.

Closed by commit rL236572: [ASan][MIPS] Fix null_deref.cc test on MIPS64 (authored by slthakur). · Explain WhyMay 5 2015, 11:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
compiler-rt/
trunk/
lib/
sanitizer_common/
2 lines

Diff 25011

compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc

Show First 20 Lines • Show All 1,056 Lines • ▼ Show 20 Lines
# else # else
*pc = ucontext->uc_mcontext.gregs[REG_PC]; *pc = ucontext->uc_mcontext.gregs[REG_PC];
*sp = ucontext->uc_mcontext.gregs[REG_O6]; *sp = ucontext->uc_mcontext.gregs[REG_O6];
stk_ptr = (uptr *) *sp; stk_ptr = (uptr *) *sp;
*bp = stk_ptr[15]; *bp = stk_ptr[15];
# endif # endif
#elif defined(__mips__) #elif defined(__mips__)
ucontext_t *ucontext = (ucontext_t*)context; ucontext_t *ucontext = (ucontext_t*)context;
*pc = ucontext->uc_mcontext.gregs[31]; *pc = ucontext->uc_mcontext.pc;
*bp = ucontext->uc_mcontext.gregs[30]; *bp = ucontext->uc_mcontext.gregs[30];
*sp = ucontext->uc_mcontext.gregs[29]; *sp = ucontext->uc_mcontext.gregs[29];
#else #else
# error "Unsupported arch" # error "Unsupported arch"
#endif #endif
} }
} // namespace __sanitizer } // namespace __sanitizer
#endif // SANITIZER_FREEBSD || SANITIZER_LINUX #endif // SANITIZER_FREEBSD || SANITIZER_LINUX