This is an archive of the discontinued LLVM Phabricator instance.

[ASan][MIPS] Fix some tests failing on MIPS64
ClosedPublic

Authored by slthakur on Apr 24 2015, 2:57 AM.

Details

Summary

Tests fixed:

AddressSanitizer-mips64-linux :: TestCases/null_deref.cc: symbol for pc was wrong.
AddressSanitizer-mips64-linux :: TestCases/Linux/quarantine_size_mb.cc : The flag quarantine_size_mb should not be compared for >=0 as it is defined as u32 type.

Diff Detail

Repository
rL LLVM

Event Timeline

slthakur updated this revision to Diff 24368.Apr 24 2015, 2:57 AM
slthakur retitled this revision from to [ASan][MIPS] Fix some tests failing on MIPS64.
slthakur updated this object.
slthakur edited the test plan for this revision. (Show Details)
slthakur added reviewers: dsanders, kcc, samsonov.
slthakur set the repository for this revision to rL LLVM.
slthakur added subscribers: jaydeep, mohit.bhakkad, Unknown Object (MLST).
samsonov added inline comments.Apr 24 2015, 11:21 AM
lib/asan/asan_flags.cc
157

No. This quarantinze_size_mb is defined in asan_flags.inc and has type int.

lib/sanitizer_common/sanitizer_linux.cc
1001

This change is OK. Feel free to commit it in a separate change.

This revision was automatically updated to reflect the committed changes.