This is an archive of the discontinued LLVM Phabricator instance.

[mlir][doc] Correct method names in DialectConversion.md to match the code.
ClosedPublic

Authored by hanchung on Dec 1 2020, 11:49 AM.

Diff Detail

Event Timeline

hanchung created this revision.Dec 1 2020, 11:49 AM
hanchung requested review of this revision.Dec 1 2020, 11:49 AM

not sure if this is correct, but the method in DialectConversion.h doesn't have s...

Just found that other methods have the same stuff, feel free to close the patch if this is intended. Or I can update other methods in the doc as well.

Just found that other methods have the same stuff, feel free to close the patch if this is intended. Or I can update other methods in the doc as well.

The docs should reflect the code, so if the docs are wrong they should be updated. Can you also update the other methods as well? Thanks for fixing this!

Side note: Can you add a bit more context(e.g. that this is related to DialectConversion) to your commit title and description?

rriddle accepted this revision.Dec 1 2020, 2:27 PM
This revision is now accepted and ready to land.Dec 1 2020, 2:27 PM
hanchung updated this revision to Diff 308887.Dec 1 2020, 11:59 PM

rename title and fix more

hanchung retitled this revision from Correct documentation. to Correct method names in DialectConversion.md to match the code..Dec 1 2020, 11:59 PM
hanchung edited the summary of this revision. (Show Details)
hanchung retitled this revision from Correct method names in DialectConversion.md to match the code. to [mlir][doc] Correct method names in DialectConversion.md to match the code..
This revision was landed with ongoing or failed builds.Dec 2 2020, 12:04 AM
This revision was automatically updated to reflect the committed changes.